Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix settings and idm admin user id configuration #3799

Merged
merged 2 commits into from
May 16, 2022
Merged

fix settings and idm admin user id configuration #3799

merged 2 commits into from
May 16, 2022

Conversation

wkloucek
Copy link
Contributor

Description

We've fixed the admin user id configuration of the settings and idm extensions.
The have previously only been configurable via the oCIS shared configuration and
therefore have been undocumented for the extensions. This config option is now part
of both extensions' configuration and can now also be used when the extensions are
compiled standalone.

Related Issue

  • Config option was missing on the extension config docs

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek requested review from rhafer, kobergj and butonic and removed request for kulmann and pascalwengerter May 16, 2022 06:30
@wkloucek wkloucek mentioned this pull request May 16, 2022
9 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mmattel
Copy link
Contributor

mmattel commented May 16, 2022

I guess that this will change the yaml file output - therefore docs relevant. Just hooking in so we can trigger a docs build.

@wkloucek wkloucek mentioned this pull request May 16, 2022
9 tasks
@wkloucek wkloucek merged commit 922d141 into owncloud:master May 16, 2022
@wkloucek wkloucek deleted the fix-settings-idm-adminuserid branch May 16, 2022 08:02
ownclouders pushed a commit that referenced this pull request May 16, 2022
Merge: 008622e 97220e6
Author: Willy Kloucek <[email protected]>
Date:   Mon May 16 10:02:40 2022 +0200

    Merge pull request #3799 from wkloucek/fix-settings-idm-adminuserid

    fix settings and idm admin user id configuration
@micbar micbar mentioned this pull request May 25, 2022
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants