Parallel deployment sharing

[wkloucek]

Description

re enables ocis / oc10 parallel deployment tests in CI and updates the deployment example.

It includes:

• fix the parallel deployment after it was broken because of the switch to REVA edge and spaces
• add the sharing functionality so that shares are shared between oCIS and oC10 🥳

Related Issue

• Enabled by Make owncloudsql spaces aware cs3org/reva#2472
• Closes [tests-only] Use built ocis server for parallel deployment tests #2951

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[ownclouders]

💥 Acceptance test settingsUITests failed. Further test are cancelled...

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[wkloucek]

@saw-jan @phil-davis I also enabled the sharing test suite because sharing across oC10 and oCIS should basicall work, but the test fails https://drone.owncloud.com/owncloud/ocis/9048/36/15:

Feature: sharing files and folders
  As a user
  I want to share files/folders with other users
  So that I can give access to my files/folders to others

  Background:                                                                                   # /drone/src/tests/parallelDeployAcceptance/features/apiShareManagement/acceptShares.feature:11
    Given using "oc10" as owncloud selector                                                     # ParallelContext::usingOwncloudSelector()
    And the administrator has set the default folder for received shares to "Shares"            # OccContext::theAdministratorHasSetTheDefaultFolderForReceivedSharesTo()
    And auto-accept shares has been disabled                                                    # FeatureContext::autoAcceptSharesHasBeenDisabled()
    And using OCS API version "1"                                                               # FeatureContext::usingOcsApiVersion()
    And using new DAV path                                                                      # FeatureContext::usingOldOrNewDavPath()
    And user "Alice" has been created with default attributes and without skeleton files        # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And user "Brian" has been created with default attributes and without skeleton files        # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And user "Alice" has uploaded file with content "ownCloud test text file" to "textfile.txt" # FeatureContext::userHasUploadedAFileWithContentTo()

  Scenario: accept a pending share                                                                # /drone/src/tests/parallelDeployAcceptance/features/apiShareManagement/acceptShares.feature:22
    Given user "Alice" has shared folder "/textfile.txt" with user "Brian"                        # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And using "ocis" as owncloud selector                                                         # ParallelContext::usingOwncloudSelector()
    When user "Brian" accepts share "/textfile.txt" offered by user "Alice" using the sharing API # FeatureContext::userReactsToShareOfferedBy()
      Sharing::userReactsToShareOfferedBy could not find share /textfile.txt, offered by Alice to Brian
      Failed asserting that null is not null.
    Then the OCS status code should be "100"                                                      # OCSContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "200"                                                      # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the sharing API should report to user "Brian" that these shares are in the accepted state # FeatureContext::assertSharesOfUserAreInState()
      | path                 |
      | /Shares/textfile.txt |

[phil-davis]

https://drone.owncloud.com/owncloud/ocis/9048/37/15
"23 scenarios (23 passed)" - that's great.

For sharing, apiShareManagement/acceptShares.feature:22 was already in tests/parallelDeployAcceptance/expected-failures-API.md so we could look into that after merging this PR.

[phil-davis]

LGTM - I did a full-ci run with this code rebased to current master in draft PR #3067 and that confirms that the full-ci functionality is still working OK with these drone changes.

[wkloucek]

LGTM - I did a full-ci run with this code rebased to current master in draft PR #3067 and that confirms that the full-ci functionality is still working OK with these drone changes.

Thanks for looking into this!

For sharing, apiShareManagement/acceptShares.feature:22 was already in tests/parallelDeployAcceptance/expected-failures-API.md so we could look into that after merging this PR.

Sharing wasn't implemented before this PR, therefore I expected that that I can remove the test from the expected failure file. I'll link to #2387 to track further progress