Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Added parallel deployment testing setup #2897

Merged
merged 1 commit into from
Dec 21, 2021
Merged

[tests-only][full-ci] Added parallel deployment testing setup #2897

merged 1 commit into from
Dec 21, 2021

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Dec 17, 2021 •
edited
Loading

Description

Set up and added some api acceptance tests for testing parallel deployment environment.

  • setup behat for testing
  • add necessary drone config for parallel setup
  • use test code from core repo

POC PR #2828

Depends on

necessary test code changes are made in this PR owncloud/core#39603

Related Issue

#2387

How Has This Been Tested?

  • local
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Dec 17, 2021
@saw-jan saw-jan changed the title [tests-only] Added parallel deployment tests [tests-only][full-ci] Added parallel deployment tests Dec 17, 2021
@saw-jan saw-jan force-pushed the parallel-deploy-tests branch 2 times, most recently from 650e2d7 to 071a7df Compare December 17, 2021 08:49
@saw-jan saw-jan changed the title [tests-only][full-ci] Added parallel deployment tests [tests-only][full-ci] Added parallel deployment testing setup Dec 17, 2021
@saw-jan saw-jan force-pushed the parallel-deploy-tests branch from 071a7df to f3c0daa Compare December 17, 2021 09:01
@saw-jan
Copy link
Member Author

saw-jan commented Dec 17, 2021 •
edited
Loading

Parallel deploy tests CI pipeline run example: https://drone.owncloud.com/owncloud/ocis/8402

For running parallel deploy test pipelines: function parallelDeployAcceptancePipeline() in starlark will generate the test pipelines

@saw-jan
Copy link
Member Author

saw-jan commented Dec 17, 2021

Parallel deployment services stack:

  • oCIS from owncloud/ocis:latest
  • oC10 from owncloud/server:10
  • openldap
  • keycloak
  • mariadb for oC10
  • postgres for keycloak

@saw-jan saw-jan force-pushed the parallel-deploy-tests branch from a4ead40 to ac0ae75 Compare December 17, 2021 10:36
@saw-jan saw-jan marked this pull request as ready for review December 17, 2021 10:36
@saw-jan saw-jan requested a review from micbar as a code owner December 17, 2021 10:36
@saw-jan saw-jan force-pushed the parallel-deploy-tests branch 3 times, most recently from 7550836 to ef9abaa Compare December 20, 2021 04:34
@phil-davis
Copy link
Contributor

@saw-jan https://drone.owncloud.com/owncloud/ocis/8431
list has no .parallelDeployAcceptancePipeline field or method

@saw-jan saw-jan force-pushed the parallel-deploy-tests branch 2 times, most recently from bb5a898 to 7c1742a Compare December 20, 2021 05:11
@saw-jan
Copy link
Member Author

saw-jan commented Dec 20, 2021

@saw-jan https://drone.owncloud.com/owncloud/ocis/8431 list has no .parallelDeployAcceptancePipeline field or method

Yeah, fixed it

@wkloucek
Copy link
Contributor

Looks like Keycloak is not set up right. But for the tests we don't even need it 😆 The testsuite is "only" using basic auth and no OpenID Connect.

I would prefer to remove Keycloak as of now from the test setup and add a comment, instead of fixing it. This also means we can skip the Keycloak database for now ;-)

Is there a way to suppress the warning WARNING: reva data root folder (/var/tmp/ocis/owncloud/) does not exist ? If so, it would be nice to do it.

Otherwise, it looks good to me

@saw-jan saw-jan force-pushed the parallel-deploy-tests branch 2 times, most recently from 214902c to f6ae9ca Compare December 21, 2021 06:18
wkloucek
wkloucek approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Runs on every PR, but since it's so fast, we can stay with it for the beginning and schedule it on nightly crons only later.

@phil-davis
Copy link
Contributor

@saw-jan please rebase. I expect that the current .drone.env is now up-to-date in master, so you will not need to change it.

@saw-jan
[POC] Tests for parallel deployment
84db46e 
add owncloud-selector cookie

working tests

remove unused files

build ocis from source branch

check users in ldap, oc10 and ocis

update proxy config

use ocis selector initially

build ocis from source

use ocis latest image

buil ocis from source

refactor

fix test run script

user 33 and alpine image for ocis server

delete local compose files

run tests with ocis latest

refactor drone config [volumes]

Run each suite in a pipeline

refactor namings

use run.sh to run tests

move TestHelpers folder

reuse behat context params

refactor to use contexts and helpers from core repo

remove contexts and helpers

added bootstrap file to bootstrap core's test files

add api tag

remove unnecessary code

implement expected-failures file

remove unnecessary confgs

fix starlark style

rename context file

add nightly trigger

refactor drone config

generate trigger as per the event

remove keycloak services
@saw-jan saw-jan force-pushed the parallel-deploy-tests branch from f6ae9ca to 84db46e Compare December 21, 2021 10:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit f448f40 into master Dec 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the parallel-deploy-tests branch December 21, 2021 14:01
@saw-jan saw-jan mentioned this pull request Dec 22, 2021
Closed
9 tasks
@individual-it individual-it mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@micbar micbar Awaiting requested review from micbar

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saw-jan @phil-davis @wkloucek