[full-ci][tests-only] Refactor test codes for parallel deployment tests #39603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
Kudos, SonarCloud Quality Gate passed!
|
saw-jan
requested review from
phil-davis,
individual-it and
kiranparajuli589
phil-davis
reviewed
Dec 17, 2021
| // oCIS cannot handle '/apps/testing' endpoints | ||
| // so those requests must be redirected to oC10 server | ||
| // change server to oC10 if the request url has `/apps/testing` | ||
| if (strpos($url, "/apps/testing") !== false) { |
There was a problem hiding this comment.
Note: in CI we always happen t have the testing app in the apps folder. Running locally, it can be in apps-external. But that should not make a difference to the API endpoint! So this should be fine.
phil-davis
reviewed
Dec 17, 2021
There was a problem hiding this comment.
Looks good. I will cherry-pick into PR #39514 and remove the bonus empty line as I do it.
11 tasks
11 tasks
|
Merged to master in #39612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made some refactoring in acceptance test codes for testing parallel deployment environment
Related Issue
Related to owncloud/ocis#2387
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: