Remove placeholder notifications endpoint in capabilities #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
reviewed
Sep 15, 2021
storage/pkg/command/frontend.go
Outdated
Comment on lines
253
to
255
| // "notifications": map[string]interface{}{ | ||
| // "endpoints": []string{"disable"}, | ||
| // }, |
There was a problem hiding this comment.
just get rid of it
Suggested change
| // "notifications": map[string]interface{}{ | |
| // "endpoints": []string{"disable"}, | |
| // }, |
pascalwengerter
force-pushed
the
15092021_remove-fake-notification
branch
from
ee84a5e to
f5df717
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
kulmann
approved these changes
Sep 16, 2021
| @@ -0,0 +1,7 @@ | |||
| Bugfix: Remove notifications placeholder | |||
|
|
|||
| Since Reva was communicating its notification capabilities incorrectly, oCIS relied on a hardcoding string to overwrite them. | |||
There was a problem hiding this comment.
Suggested change
| Since Reva was communicating its notification capabilities incorrectly, oCIS relied on a hardcoding string to overwrite them. | |
| Since Reva was communicating its notification capabilities incorrectly, oCIS relied on a hardcoded string to overwrite them. |
There was a problem hiding this comment.
Good call, fixed this in #2519
delete-merged-branch
bot
deleted the
15092021_remove-fake-notification
branch
ownclouders
pushed a commit
that referenced
this pull request
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Complementary change for cs3org/reva#1819