Remove placeholder notifications endpoint in capabilities

owncloud · Sep 15, 2021 · ee84a5e · ee84a5e
1 parent cb3a5b8
commit ee84a5e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/changelog/unreleased/remove-notifications-placeholder.md b/changelog/unreleased/remove-notifications-placeholder.md
@@ -0,0 +1,7 @@
+Bugfix: Remove notifications placeholder
+
+Since Reva was communicating its notification capabilities incorrectly, oCIS relied on a hardcoding string to overwrite them.
+This has been fixed in [reva#1819](https://github.com/cs3org/reva/pull/1819) so we now removed the hardcoded string 
+and don't modify Reva's notification capabilities anymore in order to fix clients having to poll a (non-existent) notifications endpoint.
+
+https://github.com/owncloud/ocis/pull/2514
diff --git a/storage/pkg/command/frontend.go b/storage/pkg/command/frontend.go
@@ -250,9 +250,9 @@ func frontendConfigFromStruct(c *cli.Context, cfg *config.Config, filesCfg map[s
 									"incoming": true,
 								},
 							},
-							"notifications": map[string]interface{}{
-								"endpoints": []string{"disable"},
-							},
+							// "notifications": map[string]interface{}{
+							// 	"endpoints": []string{"disable"},
+							// },
 						},
 						"version": map[string]interface{}{
 							"edition": "reva",