Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci]Adjust expected to fail for file target issue #2443

Merged
merged 1 commit into from
Aug 30, 2021
Merged

[tests-only] [full-ci]Adjust expected to fail for file target issue #2443

merged 1 commit into from
Aug 30, 2021

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Aug 27, 2021 •
edited
Loading

Description

This PR

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@SwikritiT SwikritiT mentioned this pull request Aug 27, 2021
Merged
11 tasks
@SwikritiT SwikritiT force-pushed the adjust-expectedtofail branch 3 times, most recently from 0ae0dd3 to 6215e44 Compare August 30, 2021 04:49
@phil-davis phil-davis self-requested a review August 30, 2021 04:52
@SwikritiT SwikritiT marked this pull request as ready for review August 30, 2021 05:21
@phil-davis
Copy link
Contributor

@SwikritiT this looks good and CI is going to pass.
Please squash the commits - we don't want to have commits that add the accidental file and then delete it.

@SwikritiT SwikritiT force-pushed the adjust-expectedtofail branch from 884b674 to b388954 Compare August 30, 2021 05:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT self-assigned this Aug 30, 2021
@phil-davis phil-davis merged commit c7d4f17 into master Aug 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the adjust-expectedtofail branch August 30, 2021 06:35
@SwikritiT SwikritiT mentioned this pull request Aug 30, 2021
Closed
1 task
ownclouders pushed a commit that referenced this pull request Aug 30, 2021
@phil-davis
commit c7d4f17
2555144 
Merge: 4694889 b388954
Author: Phil Davis <[email protected]>
Date:   Mon Aug 30 12:20:26 2021 +0545

    Merge pull request #2443 from owncloud/adjust-expectedtofail

    [tests-only] [full-ci]Adjust expected to fail for file target issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SwikritiT @phil-davis