Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only]Refactor tests related to file_target issue #39137

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Aug 26, 2021

Description

This PR adjusts tests related to file_target issue.

Related Issue

Motivation and Context

In OC10 after sharing a file/folder the file target contains the value Shares/<shared-resource>
But in OCIS after sharing a file/folder the file target contains the value /<shared-resource> only.
This PR splits the tests tagged to file_target issue so that they show both oc10 and ocis behavior and tags the correct issue for failing tests

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SwikritiT SwikritiT force-pushed the refactor-file-target-issue-tests branch from d7cea0b to 7b1f4f0 Compare August 27, 2021 07:01
@SwikritiT SwikritiT marked this pull request as ready for review August 27, 2021 08:28
@SwikritiT SwikritiT self-assigned this Aug 27, 2021
@SwikritiT SwikritiT force-pushed the refactor-file-target-issue-tests branch from ec9ad65 to 178f860 Compare August 27, 2021 11:14
@SwikritiT SwikritiT requested a review from saw-jan August 27, 2021 11:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 34cb226 into master Aug 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the refactor-file-target-issue-tests branch August 30, 2021 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants