Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Increase UI tests pipelines #2358

Closed
wants to merge 1 commit into from
Closed

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Aug 5, 2021

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan added the QA:team label Aug 5, 2021
@saw-jan saw-jan self-assigned this Aug 5, 2021
@update-docs
Copy link

update-docs bot commented Aug 5, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the way to go. It's not sustainable, we need to figure out how to speed up the tests inside web

@pascalwengerter
Copy link
Contributor

Also, @phil-davis this is the third time in the last 24h that your team has made multiple PRs with identical changes in the same repo. Please coordinate this better

@pascalwengerter pascalwengerter deleted the split-uitests branch August 5, 2021 10:10
@phil-davis
Copy link
Contributor

@saw-jan for now, I did this in #2353 because we are having trouble today just to get CI finished for that PR.

And we will have to look into the detail of the tests tomorrow.

@saw-jan
Copy link
Member Author

saw-jan commented Aug 5, 2021

Yeah, I noticed now.
I just took at it because the issue was in our sprint

@phil-davis
Copy link
Contributor

Also, @phil-davis this is the third time in the last 24h that your team has made multiple PRs with identical changes in the same repo. Please coordinate this better

yes, sure. This one happened because of the struggle to get CI finished for #2353 - I made a quick push to that PR only minutes ago to get it going in real-time. So I didn't have the chance yet to communicate that with others. And @saw-jan made this PR almost at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants