Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Update web to 4.0.0 #2353

Merged
merged 4 commits into from
Aug 5, 2021
Merged

[full-ci] Update web to 4.0.0 #2353

merged 4 commits into from
Aug 5, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Aug 4, 2021

Update web to release 4.0.0

@kulmann kulmann mentioned this pull request Aug 4, 2021
Closed
phil-davis
phil-davis approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I adjusted the expected-failures. All the needed adjustments were either due to adjustments of test scenarios in web, new test scenarios in web or tests that are now passing. They all looked like good and reasonable changes.

fschade
fschade approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets wait for the ci then 🚀

@phil-davis phil-davis mentioned this pull request Aug 5, 2021
Merged
@phil-davis
Copy link
Contributor

One of the web test pipelines ran for 2 hours and drone auto-cancelled the pipeline. The drone agent seemed to be running very slowly - super frustrating. I have stopped the oldest drone agents, so they will not be given pipelines. I restarted CI. Let's see if we do better this time.

@phil-davis
Copy link
Contributor

phil-davis commented Aug 5, 2021 •
edited
Loading

I am fixing up the drone starlark to split web pipelines into more parts... (some are taking 2 hours!)

Edit: done

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@phil-davis phil-davis mentioned this pull request Aug 5, 2021
Closed
9 tasks
@saw-jan saw-jan mentioned this pull request Aug 5, 2021
Closed
@phil-davis phil-davis merged commit aab73be into master Aug 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-web-4.0.0 branch August 5, 2021 11:39
ownclouders pushed a commit that referenced this pull request Aug 5, 2021
@phil-davis
commit aab73be
988eaaa 
Merge: 69dfdea ed3a5a7
Author: Phil Davis <[email protected]>
Date:   Thu Aug 5 17:24:16 2021 +0545

    Merge pull request #2353 from owncloud/update-web-4.0.0

    [full-ci] Update web to 4.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

@individual-it individual-it individual-it approved these changes

@phil-davis phil-davis phil-davis approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@micbar micbar Awaiting requested review from micbar

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kulmann @phil-davis @individual-it @fschade @pascalwengerter