-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thumbnails for public links #1898
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
25b2f9d
to
0f1115d
Compare
80662b3
to
85265b0
Compare
The webui tests are failing because the tests are using the owncloud storage driver, which doesn't return checksums for the files. |
Closes #1473 |
fc71ab2
to
5fcb602
Compare
closes #192 as well? |
No, because it's not fully implementing it. |
5fcb602
to
cafd9d0
Compare
1063bd5
to
362a336
Compare
Yeah, for public links we still need to update web in oCIS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider commenting exported members of a struct or the linter is going to have a hard time 🤖 or humans are going to have a hard time 🧑🦱
I get 400 errors with current web master branch
|
362a336
to
23fa514
Compare
Hm that is strange. I just tried it on my machine again and it just works with the current web master. 🤔 |
I did try it again and it now works in every case when using folders. But I did not manage to get thumbnails when I share a single picture with a public link Log:
|
@refs Only if I share a single photo, no thumbnail is displayed. In your screenshot I can see multiple files shared, so you shared the folder and not a file. |
@wkloucek ah, misread, let me try that edit: got the same results as you, the single share thumbnail is not displayed. |
23fa514
to
f89cff4
Compare
@wkloucek @refs, I debugged the single file public link and found the issue. In my opinion we could merge this here and update reva later but I'm also fine with waiting until reva was updated. By the way, single file public links were already broken for a long time, not only thumbnails but also downloading and so on. We just never noticed it seems. 😅 |
|
- Implement a CS3 image source handler - Use checksum instead of etag for unique check - Simplify storage layout
f89cff4
to
af03099
Compare
Kudos, SonarCloud Quality Gate passed! |
can confirm single file share works just fine with Reva's patches /cc @C0rby |
This PR introduces some long needed changes to the thumbnails service and introduces support for public links.