-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use default paths #1049
use default paths #1049
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simpler is better. We now have one ocis-data volume that has everything. that is good.
Do we have documentation that explains the variables that are no longer used in the yml files?
Usage in docker-compose.yml was the documanttion I knew so far.
Can you add a link to that documentation to the yml files, or something similar?
@micbar for [docs-only] PRs the unit tests are not run, and so there are no coverage reports and CI does not do SonarCloud analysis. That means that "SonarCloud Code Analysis" is not always "required" for PRs in this repo. But I doubt that GitHub can be told the rule for when "SonarCloud Code Analysis" is required or not. What to do? |
a037ef4
to
c6c5f71
Compare
c6c5f71
to
89f1831
Compare
Yes. there is no condition possible in the Rule. Was it blocking the merge? |
89f1831
to
fba1047
Compare
Like #1046 this is blocked only by SonarCloud. |
fba1047
to
e767827
Compare
e767827
to
80c8fd3
Compare
Kudos, SonarCloud Quality Gate passed! |
This reverts all path settings to default. This seems more simple and less to break for the example deployments.
For example the current deployment examples do not start properly because of a missing folder structure. Also not everything was persisted, eg. because of missing
STORAGE_SHARING_USER_JSON_FILE
.Path logic will be also tackled in #1048