Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use default paths #1049

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Dec 10, 2020

This reverts all path settings to default. This seems more simple and less to break for the example deployments.

For example the current deployment examples do not start properly because of a missing folder structure. Also not everything was persisted, eg. because of missing STORAGE_SHARING_USER_JSON_FILE.

ocis_1     | 2020-12-09T22:27:40Z ERR error starting the grpc server error="unable to register services: rgrpc: grpc service usershareprovider could not be started,: error loading the file containing the shares: error opening/creating the file: /var/tmp/ocis/shares.json: open /var/tmp/ocis/shares.json: no such file or directory" service=storage
ocis_1     | process [storage-sharing] exited with code: 1

Path logic will be also tackled in #1048

@update-docs
Copy link

update-docs bot commented Dec 10, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested a review from jnweiger December 10, 2020 12:39
Copy link
Contributor

@jnweiger jnweiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simpler is better. We now have one ocis-data volume that has everything. that is good.

Do we have documentation that explains the variables that are no longer used in the yml files?
Usage in docker-compose.yml was the documanttion I knew so far.
Can you add a link to that documentation to the yml files, or something similar?

@phil-davis
Copy link
Contributor

@micbar for [docs-only] PRs the unit tests are not run, and so there are no coverage reports and CI does not do SonarCloud analysis. That means that "SonarCloud Code Analysis" is not always "required" for PRs in this repo. But I doubt that GitHub can be told the rule for when "SonarCloud Code Analysis" is required or not.

What to do?

@wkloucek wkloucek force-pushed the use_default_path_for_example_deployments branch 2 times, most recently from a037ef4 to c6c5f71 Compare December 10, 2020 13:50
@wkloucek wkloucek changed the title [docs-only] use default paths use default paths Dec 10, 2020
@wkloucek wkloucek force-pushed the use_default_path_for_example_deployments branch from c6c5f71 to 89f1831 Compare December 10, 2020 15:45
@micbar
Copy link
Contributor

micbar commented Dec 10, 2020

@micbar for [docs-only] PRs the unit tests are not run, and so there are no coverage reports and CI does not do SonarCloud analysis. That means that "SonarCloud Code Analysis" is not always "required" for PRs in this repo. But I doubt that GitHub can be told the rule for when "SonarCloud Code Analysis" is required or not.

What to do?

Yes. there is no condition possible in the Rule.

Was it blocking the merge?

@wkloucek wkloucek changed the title use default paths [docs-only] use default paths Dec 10, 2020
@wkloucek wkloucek force-pushed the use_default_path_for_example_deployments branch from 89f1831 to fba1047 Compare December 10, 2020 17:05
@wkloucek
Copy link
Contributor Author

@micbar for [docs-only] PRs the unit tests are not run, and so there are no coverage reports and CI does not do SonarCloud analysis. That means that "SonarCloud Code Analysis" is not always "required" for PRs in this repo. But I doubt that GitHub can be told the rule for when "SonarCloud Code Analysis" is required or not.
What to do?

Yes. there is no condition possible in the Rule.

Was it blocking the merge?

Like #1046 this is blocked only by SonarCloud.

@wkloucek wkloucek force-pushed the use_default_path_for_example_deployments branch from fba1047 to e767827 Compare December 11, 2020 07:52
@wkloucek wkloucek changed the title [docs-only] use default paths use default paths Dec 11, 2020
@wkloucek wkloucek force-pushed the use_default_path_for_example_deployments branch from e767827 to 80c8fd3 Compare December 11, 2020 08:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit 64a39ff into master Dec 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the use_default_path_for_example_deployments branch December 11, 2020 09:20
@wkloucek wkloucek mentioned this pull request Dec 11, 2020
ownclouders pushed a commit that referenced this pull request Dec 11, 2020
Merge: 78d2647 80c8fd3
Author: Willy Kloucek <[email protected]>
Date:   Fri Dec 11 10:20:25 2020 +0100

    Merge pull request #1049 from owncloud/use_default_path_for_example_deployments

    use default paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants