Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-only] make menu lists collapsed #1046

Merged
merged 1 commit into from
Dec 11, 2020
Merged

[docs-only] make menu lists collapsed #1046

merged 1 commit into from
Dec 11, 2020

Conversation

wkloucek
Copy link
Contributor

Will make use of collapsable menu items: thegeeklab/hugo-geekdoc#23

Will only take effect after merging: owncloud/owncloud.github.io#21

Solves: owncloud/owncloud.github.io#20

@update-docs
Copy link

update-docs bot commented Dec 10, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested a review from micbar December 10, 2020 09:13
@wkloucek wkloucek mentioned this pull request Dec 10, 2020
Merged
@wkloucek wkloucek requested a review from kulmann December 11, 2020 09:25
kulmann
kulmann requested changes Dec 11, 2020
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is a really good improvement, there are two sections missing now with this PR. We had one clients and one integrations section. Both are missing when I run the docs locally.

@wkloucek
Copy link
Contributor Author

wkloucek commented Dec 11, 2020 •
edited
Loading

While this is a really good improvement, there are two sections missing now with this PR. We had one clients and one integrations section. Both are missing when I run the docs locally.

Those might come from another repository like Phoenix and oCIS Hello do. This is not caused by this ;-)

kulmann
kulmann approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you're right! :-) Thanks for reminding me. Cool, then this is good to go! 🚀

@wkloucek wkloucek merged commit ea2a2b3 into master Dec 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the enable_collapse_docs branch December 11, 2020 12:29
ownclouders pushed a commit that referenced this pull request Dec 11, 2020
@wkloucek
commit ea2a2b3
2ef203c 
Merge: 67f727d 98b226c
Author: Willy Kloucek <[email protected]>
Date:   Fri Dec 11 13:29:11 2020 +0100

    Merge pull request #1046 from owncloud/enable_collapse_docs

    [docs-only] make menu lists collapsed
This was referenced Dec 11, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@micbar micbar Awaiting requested review from micbar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @kulmann