Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA][OCM] no notification when receiving a federated share #10718

Open
Tracked by #10971
jnweiger opened this issue Dec 3, 2024 · 4 comments
Open
Tracked by #10971

[QA][OCM] no notification when receiving a federated share #10718

jnweiger opened this issue Dec 3, 2024 · 4 comments
Assignees
Labels

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Dec 3, 2024

Describe the bug

When a file or folder is shared with a local user, this user receives a notification.
The same should happen with a remote user, receiving a federated share.

Steps to reproduce

Setup two machines with e.g.

env OCIS_DNSNAME=cat-7rc3-DATE OCIS_VERSION=v7.0.0-rc.3 ./deploy_ocis_bare_metal.sh
env OCIS_DNSNAME=elf-7rc3-DATE OCIS_VERSION=v7.0.0-rc.3 ./deploy_ocis_bare_metal.sh

mutually register the machines in their ocmproviders.json; service ocis restart

Alice creates a folder and uploads an mp4 file there.
Alice shares the folder with local user bob and with external user carol with edit permission.

Bob receives a notification. OK
Carol does not get any notification. BAD.

Expected behavior

image

Actual behavior

image

Setup

Please describe how you started the server and provide a list of relevant environment variables or configuration files.

OCIS_XXX=somevalue
OCIS_YYY=somevalue
PROXY_XXX=somevalue

Additional context

Add any other context about the problem here.

@hodyroff fyi.

@prashant-gurung899
Copy link
Contributor

Infinite Scale 7.1.0-rc.2+ba924e757d Community
ownCloud Web UI 11.1.0

There is still no notification for received federated share.
So re-opening this issue.

Screencast.from.20-1-25.10.03.05.+0545.webm

@kobergj
Copy link
Collaborator

kobergj commented Jan 23, 2025

@2403905 as discussed yesterday. Just finish what you already started. We currently do NOT need notifications for federated shares but should be prepared when someone requests it.

@jvillafanez
Copy link
Member

While it won't be in the 7.1 release (too late to include), I think it's important enough to be implemented as soon as possible. There are quite a bunch of UX problems at the moment:

  • Sender doesn't know if the receiver has gotten the share. Taking into account that we're connecting to an external system, an explicit confirmation that the receiver got the share might be better.
  • Receiver doesn't know when the share is available:
    • There is no UI notification, so the user can access some files, edit documents and close the session without knowing that a he has a new file available that has been shared from another instance.
    • The user won't check the shares for new files. He either access his personal space or other spaces in order to work with people, but he'll only access the shares if we wants to download a file that he knows is already there.

Right now, it seems to me there is a required "offline communication": the sender needs to tell the receiver that he will share a file with him, and this communication needs to happen outside of ownCloud (via email, chat, call, etc).

@2403905
Copy link
Contributor

2403905 commented Feb 5, 2025

Based on API the communications between provider and recipient going through the notifications
https://cs3org.github.io/OCM-API/docs.html?branch=develop&repo=OCM-API&user=cs3org#/paths/~1notifications/post

The notification endpoint is not implemented. I'm working on ocm unshare that will uses a notification endpoint https://github.com/owncloud/enterprise/issues/7075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

No branches or pull requests

6 participants