Skip to content

Commit

Permalink
Merge pull request #3833 from wkloucek/registry-cache
Browse files Browse the repository at this point in the history
introduce service registry cache
  • Loading branch information
butonic authored May 19, 2022
2 parents 47b6904 + b596d1d commit 49cac99
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
7 changes: 7 additions & 0 deletions changelog/unreleased/enhancement-registry-cache.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Enhancement: Introduce service registry cache

We've improved the service registry / service discovery by
setting up registry caching (TTL 20s), so that not every requests
has to do a lookup on the registry.

https://github.com/owncloud/ocis/pull/3833
6 changes: 5 additions & 1 deletion ocis-pkg/registry/registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package registry
import (
"os"
"strings"
"time"

consulr "github.com/go-micro/plugins/v4/registry/consul"
etcdr "github.com/go-micro/plugins/v4/registry/etcd"
Expand All @@ -11,6 +12,7 @@ import (
natsr "github.com/go-micro/plugins/v4/registry/nats"

"go-micro.dev/v4/registry"
"go-micro.dev/v4/registry/cache"
)

var (
Expand Down Expand Up @@ -46,5 +48,7 @@ func GetRegistry() registry.Registry {
r = mdnsr.NewRegistry()
}

return r
// always use cached registry to prevent registry
// lookup for every request
return cache.New(r, cache.WithTTL(20*time.Second))
}

0 comments on commit 49cac99

Please sign in to comment.