introduce service registry cache

owncloud · May 19, 2022 · b596d1d · b596d1d
1 parent b788552
commit b596d1d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/changelog/unreleased/enhancement-registry-cache.md b/changelog/unreleased/enhancement-registry-cache.md
@@ -0,0 +1,7 @@
+Enhancement: Introduce service registry cache
+
+We've improved the service registry / service discovery by
+setting up registry caching (TTL 20s), so that not every requests
+has to do a lookup on the registry.
+
+https://github.com/owncloud/ocis/pull/3833
diff --git a/ocis-pkg/registry/registry.go b/ocis-pkg/registry/registry.go
@@ -3,6 +3,7 @@ package registry
 import (
 	"os"
 	"strings"
+	"time"
 
 	consulr "github.com/go-micro/plugins/v4/registry/consul"
 	etcdr "github.com/go-micro/plugins/v4/registry/etcd"
@@ -11,6 +12,7 @@ import (
 	natsr "github.com/go-micro/plugins/v4/registry/nats"
 
 	"go-micro.dev/v4/registry"
+	"go-micro.dev/v4/registry/cache"
 )
 
 var (
@@ -46,5 +48,7 @@ func GetRegistry() registry.Registry {
 		r = mdnsr.NewRegistry()
 	}
 
-	return r
+	// always use cached registry to prevent registry
+	// lookup for every request
+	return cache.New(r, cache.WithTTL(20*time.Second))
 }