Allow impersonation if the target is in at least one of the allowed groups #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
Closed
phil-davis
requested review from
mrow4a,
jnweiger,
JammingBen and
AlexAndBear
mrow4a
requested changes
Sep 15, 2022
mrow4a
approved these changes
Sep 15, 2022
delete-merged-branch
bot
deleted the
refactor-targetIsInAtLeastOneOfTheAppEnabledGroupIds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See my comment #206 (comment)
The requirement should be that the target user can be impersonated if they are in any of the groups for which impersonation is allowed. This PR implements that logic.
With the original logic, the target user had to be a member of every group in the list.