[QA] 0.5.2 Testplan

[jnweiger]

Setup

• https://oc10110rc2-impersonate-052rc1-20220915.jw-qa.owncloud.works

Impersonate Test Plan

Test Case	Expected Result	Result	Related Comment
Enable the app.	No problems found.	✔️
As admin create a group 'group1' add three members 'user1', 'user2', 'user3'. Make 'user1' group admin of 'group1'. Login as 'user1', go to the users view. Impersonate 'user2'.	'user1' can impersonate 'user2'. See his files. Behave like him. Like if he were logged in.	✔️
Check that a user who is not group admin cannot impersonate anyone.		✔️
As admin create a group 'group1' add four members 'user1', 'user2', 'user3' and 'admin' being admin user of the server. Make 'user1' group admin of 'group1'. Login as 'user1', go to the users view. Impersonate 'admin'.	Super admin cannot be impersonated.	✔️
When impersonating a user, a warning appears adverting that you have logged as another user.	a warning appears and disappears after a while.	✔️
Check that impersonate options appears in the correct settings panel.		✔️
Interaction with other Apps
Having ldap set up, enable impersonation for an ldap group. Make a user group admin. Using that user impersonate one of the other members of the ldap group.	Users can be impersonated without problems.	✔️
A guest user cannot impersonate other users.		✔️
Browsers
Check that all the UI elements are usable when browsing with safari.		✔️
Check that all the UI elements are usable when browsing with chrome.		✔️
Check that all the UI elements are usable when browsing with firefox.		✔️
Check that all the UI elements are usable when browsing with edge.		✔️
Check that all the UI elements are usable when browsing with IE11.		🦘

---

[jnweiger]

Issues to re-review

• Group list from Allow group admins of specific groups to impersonate the users within those groups should be updated if we delete a group in the server #142
• [master branch] The group selection in "User Authentication" page doesn't work in  #104

Changelog testing

• restrict impersonation to users allowed to use the app #202
  • enable impersonate
  • make alice group admin of group alice-g, add user dave to alice-g
  • log in as alice, there is now a Users menu, where alice can see dave, and has an impersonate icon
  • per default, impersonate does not work. This is a breaking change.
  • occ config:app:set impersonate impersonate_all_groupadmins --value true -> now alice can impersonate dave.
• https://github.com/owncloud/enterprise/issues/5167
  • admin impersonates alice, as alice we click log out, we are back as admin

[phil-davis]

@jnweiger I was going to try some scenario with multiple groups related to #202 because, from seeing the code, I think that there might be a problem.

I have groups called clients contractors staff. I want to make it so that only staff can be impersonated. User peter is a member of group staff. When I do:

php occ config:app:set impersonate enabled --value '["staff"]

then I expect that the admin will be able to impersonate peter but will not be able to impersonate other users.

But when I login as admin and go to the Users page, I don't see the "impersonate icon" for any of the users. And I don't see the Admin Settings, User Authentication setting any more.

The app settings are:

$ php occ config:list impersonate
{
    "apps": {
        "impersonate": {
            "enabled": "[\"staff\"]",
            "installed_version": "0.5.2",
            "types": ""
        }
    }
}

I suspect that something in core does not even think that the app is enabled, because "enabled" is not set to "yes".

It seems strange that the app enabled setting (normally "yes" or "no") now also has the possibility of being an array of group names. Edit: now I realize that there is a general app functionality that lets an app be enabled only for particular users. So that is not a really special thing for this app.

[phil-davis]

Now I understand that both the impersonator (usually an admin, or a subadmin of a group) has to be in one of the allowed groups, and also the target user (impersonatee - is that a word) also has to be in one of the allowed groups.

If I do:

php occ config:app:set impersonate enabled --value '["admin","staff"]

then I get closer. The admin user (who is in the admin group) can now go to the Users page and see the Impersonate icon for other users. But it will not let me impersonate any user. Even though user peter is in group staff, it will not let admin impersonate him.

The problem is that the code, accidentally, only allows a user to be impersonated if they are a member of every group in the list of allowed groups.

I adjusted the logic of that in PR #208 and now admin can impersonate user peter in group staff but cannot impersonate other users.

[phil-davis]

@jnweiger there were a lot of changes merged to the release branch yesterday. I think the code should be good now. Needs another RC built, and test with that.

[phil-davis]

@jnweiger I guess that this issue can be closed?