Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unit tests into tests/unit folder #198

Closed
phil-davis opened this issue Mar 14, 2022 · 3 comments
Closed

Move unit tests into tests/unit folder #198

phil-davis opened this issue Mar 14, 2022 · 3 comments
Assignees
Labels

Comments

@phil-davis
Copy link
Contributor

The unit tests are currently directly inside the tests folder. Create tests/unit and move the unit tests there.

Related to owncloud/activity#1074 - the logic to decide if a unit test has changed depends on the unit tests being in a directory called tests/unit

@phil-davis
Copy link
Contributor Author

phil-davis commented Mar 14, 2022

Whoever does this, look at other oC10 app repos that have the unit tests in tests/unit and do the same.

And there are some apps that have the unit tests in tests/Unit (with an uppercase "U"). Change the to lowercase tests/unit to make everything consistent.

Tidy up phpunit.xml while doing this issue - make it as consistent as possible in each oC10 app repo.

@phil-davis
Copy link
Contributor Author

@grgprarup FYI I edited my comment #198 (comment)

Please see how much we can make phunit.xml (and any other unit test scripts, settings etc) consistent in "every" oC10 app.

@SagarGi SagarGi self-assigned this May 18, 2022
This was referenced May 18, 2022
@SagarGi
Copy link
Member

SagarGi commented May 27, 2022

Covered up all the apps having drone star and having phpunit tests. So closing this issue.

@SagarGi SagarGi closed this as completed May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants