Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Tidy up the phpunit xml file for calendar app #1254

Merged
merged 1 commit into from
May 19, 2022
Merged

[tests-only][full-ci]Tidy up the phpunit xml file for calendar app #1254

merged 1 commit into from
May 19, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented May 19, 2022

This PR moves unit tests into tests/unit folder. And also tidy up the phpunit.xml to make standard format for all oc-apps as much as possible.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SagarGi SagarGi marked this pull request as ready for review May 19, 2022 08:56
@SagarGi SagarGi self-assigned this May 19, 2022
phil-davis
phil-davis approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: for this app, the unit tests were already in tests/unit so they did not need to be moved.

@phil-davis phil-davis merged commit 664a3c6 into master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SagarGi @phil-davis