[tests-only][full-ci] Improve Then step in apiWebdavEtagPropagation2 suite #39950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrita-shrestha
commented
Apr 5, 2022
| @@ -13,7 +13,7 @@ Feature: propagation of etags when uploading data | |||
| And user "Alice" has stored etag of element "/" | |||
| And user "Alice" has stored etag of element "/upload" | |||
| When user "Alice" uploads file with content "uploaded content" to "/upload/file.txt" using the WebDAV API | |||
| Then the content of file "/upload/file.txt" for user "Alice" should be "uploaded content" | |||
There was a problem hiding this comment.
As artur suggested we are testing the etags in this suite with the fact that the code is correct after When step action in other #39944 (comment). I think removing this step will provide consistency in the suite.
Same applies to the below scenario ( line 39 )
amrita-shrestha
force-pushed
the
improveThenStepInApiWebdavEtagPropagation2
branch
from
9bbfeb7 to
b5f2c2a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
individual-it
approved these changes
Apr 6, 2022
delete-merged-branch
bot
deleted the
improveThenStepInApiWebdavEtagPropagation2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
Thensteps to existing API test scenarios to better check the results of theWhensteps.Suites covered:
apiWebdavEtagPropagation2Related Issue
How Has This Been Tested?
Types of changes
Checklist: