Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Improve Then step in apiWebdavEtagPropagation1 suite #39944

Merged
merged 1 commit into from
Apr 6, 2022
Merged

[tests-only][full-ci] Improve Then step in apiWebdavEtagPropagation1 suite #39944

merged 1 commit into from
Apr 6, 2022

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR adds Then steps to existing API test scenarios to better check the results of the When steps.

Suites covered:

  • apiWebdavEtagPropagation1

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@amrita-shrestha amrita-shrestha self-assigned this Apr 4, 2022
@amrita-shrestha amrita-shrestha marked this pull request as ready for review April 4, 2022 05:24
kiranparajuli589
kiranparajuli589 reviewed Apr 4, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

grgprarup
grgprarup reviewed Apr 4, 2022
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@amrita-shrestha amrita-shrestha force-pushed the improveThenStepInApiWebdavEtagPropagation1 branch from 2717fbe to 1d39bbd Compare April 5, 2022 04:08
@amrita-shrestha amrita-shrestha mentioned this pull request Apr 5, 2022
Merged
11 tasks
@amrita-shrestha amrita-shrestha force-pushed the improveThenStepInApiWebdavEtagPropagation1 branch from 1d39bbd to 5ff298b Compare April 5, 2022 05:40
@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SwikritiT
SwikritiT reviewed Apr 5, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@individual-it individual-it merged commit a0f849e into master Apr 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the improveThenStepInApiWebdavEtagPropagation1 branch April 6, 2022 07:20
@amrita-shrestha amrita-shrestha mentioned this pull request Apr 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@grgprarup grgprarup grgprarup left review comments

@individual-it individual-it individual-it approved these changes

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amrita-shrestha @individual-it @grgprarup @kiranparajuli589 @SwikritiT