Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] Added Then steps to improve checks in tests for apiProvisioning-v1 suite #39834

Merged
merged 1 commit into from
Mar 1, 2022
Merged

[tests-only] [full-ci] Added Then steps to improve checks in tests for apiProvisioning-v1 suite #39834

merged 1 commit into from
Mar 1, 2022

Conversation

grgprarup
Copy link
Contributor

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suites covered:

  • apiProvisioning-v1

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@grgprarup grgprarup self-assigned this Feb 28, 2022
@grgprarup grgprarup mentioned this pull request Feb 28, 2022
Closed
@grgprarup grgprarup requested review from SwikritiT and SagarGi and removed request for saw-jan February 28, 2022 11:15
@phil-davis
Copy link
Contributor

@grgprarup please rebase to the latest master. I just merged PR #39688 and that added some scenarios to editUser.feature

Then check the new scenarios - they might need to have HTTP status checks etc added to them.

@grgprarup grgprarup force-pushed the improve-then-steps-in-apiProvisioning-v1 branch 2 times, most recently from a3b44b7 to e5bea05 Compare March 1, 2022 04:12
@grgprarup grgprarup force-pushed the improve-then-steps-in-apiProvisioning-v1 branch from e5bea05 to 8a65e2b Compare March 1, 2022 04:49
@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kiranparajuli589
kiranparajuli589 reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@phil-davis phil-davis merged commit 4512f46 into master Mar 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the improve-then-steps-in-apiProvisioning-v1 branch March 1, 2022 11:46
This was referenced Mar 3, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grgprarup @phil-davis @kiranparajuli589