Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Tests and fix for issue 39687 #39688

Merged
merged 6 commits into from
Feb 28, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 13, 2022

Description

These test scenarios will fail because of issue #39687.

I added the fixes to the code (see 3rd commit). CI should pass.

ToDo:

  • add unit tests to cover this stuff
  • test the case of a subadmin who has permissions over a user. The subadmin should be able to change email and display name always.

Related Issue

#39687

How Has This Been Tested?

Local test runs of the new scenarios

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/core/34302/54/13

runsh: Total unexpected failed scenarios throughout the test run:
apiProvisioning-v1/editUser.feature:226
apiProvisioning-v1/editUser.feature:259

https://drone.owncloud.com/owncloud/core/34302/55/13

runsh: Total unexpected failed scenarios throughout the test run:
apiProvisioning-v2/editUser.feature:227
apiProvisioning-v2/editUser.feature:260

Those are the new test scenarios, which I expect to fail.

@phil-davis phil-davis changed the title [tests-only] [full-ci] Tests for issue 39687 [tests-only] [full-ci] Tests and fix for issue 39687 Jan 13, 2022
@phil-davis phil-davis force-pushed the tests-for-issue-39687 branch from b7c40e9 to 187848a Compare January 14, 2022 03:21
@phil-davis
Copy link
Contributor Author

phil-davis commented Jan 14, 2022

https://drone.owncloud.com/owncloud/core/34305/151/17
webUIUpload/upload.feature:131 failed
unrelated
issue #39549

@jvillafanez
Copy link
Member

I'd also include the fix for the migration (commented in #39687 (comment)) as part of this PR. The fix should be just including null as default value for the getValue call.
It's also easy to manually verify that the problem is solved just by checking a fresh installation

@phil-davis phil-davis force-pushed the tests-for-issue-39687 branch 2 times, most recently from fc22161 to 31986d6 Compare January 17, 2022 16:19
@phil-davis phil-davis force-pushed the tests-for-issue-39687 branch from 31986d6 to 02538cb Compare February 7, 2022 09:26
@phil-davis phil-davis force-pushed the tests-for-issue-39687 branch from 02538cb to a241930 Compare February 28, 2022 09:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants