[Tests-Only] Have separate scenarios for public link share of root folder on oC10 and OCIS

[phil-davis]

Description

On ownCloud10 a user cannot make a public link share of their root folder. That behaviour stays the same on ownCloud10, but will be different on OCIS. So tag the ownCloud10 scenario with notToImplementOnOCIS

On OCIS a user will be allowed to make a public link share of their root folder. Write a new scenario for the expected OCIS behaviour. Tag it skipOnOcV10 because that is not the expected behaviour on oC10.

Related Issue

Implements API tests for https://github.com/owncloud/ocis-reva/issues/283

How Has This Been Tested?

CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[phil-davis]

For discussion: what approach should we take when there is an agreed difference in behaviour between implementations of the OCS APIs? In this case the implementations are ownCloud10 and OCIS. There might be an agreed difference between OCIS and cs3org/reva for something. There might be some other implementation in the future...

At the moment, the API tests here in owncloud/core are being used as the "defined standard" to make pass in order to be a "good implementation" of the OCS and WebDav APIs.

Approaches we could take when the "defined standard" has been agreed to be different for different implementations include:

1. do what I have done here - add the different scenarios to the "common" test suite with tags to indicate which implementations do or do not implement the scenario.

2. keep just the oC10 behaviour in owncloud/core, put the scenarios for the different behaviour into the repos with the other implementation (e.g. this new scenario could be put inot owncloud/ocis)

[codecov]

Codecov Report

Merging #37943 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37943   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity    19442    19442           
=========================================
  Files          1286     1286           
  Lines         76022    76022           
  Branches       1336     1336           
=========================================
  Hits          49196    49196           
  Misses        26432    26432           
  Partials        394      394           

Flag	Coverage Δ	Complexity Δ
#javascript	54.06% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.88% <ø> (ø)	19442.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ca68a6...a1249bb. Read the comment docs.

[individual-it]

I would vote for the 1. approach like done in this PR. Then we know that all the "good" tests are in this repo