Prevent creating public share for the home root folder

[PVince81]

in apiSharePublicLink1/createPublicLinkShare.feature scenario "Do not allow public sharing of root"

It returns 200 instead of 403

[pmaier1]

Product decision: Going forward we want to allow this via API. Please adjust the tests accordingly.

[phil-davis]

@pmaier1 Are we going to allow public share of the user's root folder in oC10 also?

Or do we make the tests know that the expected behaviour is different on oC10 and OCIS?

[phil-davis]

Added QA-team label so that we notice this to adjust the tests.

[pmaier1]

@pmaier1 Are we going to allow public share of the user's root folder in oC10 also?

No, this is only for OCIS.

[individual-it]

Do we also need UI tests for that? @pmaier1 should it also be possible via UI aka. phoenix?

[phil-davis]

API test scenario is added in owncloud/core#37943
When that read-only scenario works in OCIS, then some permissions combinations should be added - to also check that files can be uploaded, deleted... I did not write them now, but I suppose I could - the desired behaviour with different/greater permissions should not be difficult to write down.

[pmaier1]

Do we also need UI tests for that? @pmaier1 should it also be possible via UI aka. phoenix?

Currently that functionality is only for API. This ticket originally was about preventing this in OCIS because we have an oc10 test that tells so. After discussion we rather consider this as a limitation in oc10 which is why we decided to adjust the tests instead of changing the behavior.

[phil-davis]

Removed my assignment - owncloud/core#37943 sorted out the 2 scenarios for the different behaviour.

[phil-davis]

The core scenario is currently still failing on OCIS due to an unexpected OCS status code. When that is sorted out, maybe the rest of the checks will pass.

[refs]

The core scenario is currently still failing on OCIS due to an unexpected OCS status code. When that is sorted out, maybe the rest of the checks will pass.

This seems like a quick win, cc @micbar

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

[micbar]

@butonic @individual-it fixing the status code looks like a quick win

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

[phil-davis]

owncloud/core#37943 implemented separate test scenarios for this on oC10 and oCIS.

On oCIS, creating a public link share of the root is allowed. The behavior on oC10 and oCIS is accepted to be different.