Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[For 10.4] Add dir/path sharing infos #36254
[For 10.4] Add dir/path sharing infos #36254
Changes from all commits
8105173
0f4ce7c
729717e
7a43227
e3969f9
845bf20
055dea2
f9387dd
774e8f3
402cdee
9e155f3
6606f0c
e900982
996b880
ea7a0c2
7e66f37
ebcc07c
c5ff1a6
9509462
c8941e3
43f7a32
410f6ef
1da9ff0
fc593bc
922bb99
9de5f64
0c9614b
9f4dc49
0538e87
eeae701
eb73610
5b3f970
1d38b3b
36750d9
8970f86
cfbc35c
f413df3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no risk of infinite loop here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I did was wrapping it in a Promise so I could act after the reload was done.
This seems to have worked for the last 5 years ;-)