-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[For 10.4] Add dir/path sharing infos #36254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine so far, except for the missing docs.
Now to see how this will be used
0b9b03f
to
a26dc88
Compare
Codecov Report
@@ Coverage Diff @@
## master #36254 +/- ##
===========================================
+ Coverage 64.68% 65.18% +0.5%
- Complexity 19023 19794 +771
===========================================
Files 1268 1271 +3
Lines 74362 74736 +374
Branches 1309 1310 +1
===========================================
+ Hits 48100 48719 +619
+ Misses 25876 25630 -246
- Partials 386 387 +1
Continue to review full report at Codecov.
|
fa17e25
to
6f7d2c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
92b667b
to
ea6253f
Compare
@PVince81 there is no need to merge it yet, but if the code is fine, we can supply a patch to the customer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine so far except for the concern about scrolling to the next page where items are rendered dynamically. Once this is solved this could be tested as patch.
Also, before we merge this we must add JS unit tests.
3ee5b4f
to
d3078ab
Compare
Open share by clicking on shareTree item
…ing for resources marked as shared
360155b
to
8970f86
Compare
…ed/received-shared resources
See #36534 for a rebased/squashed version of this. |
closing in favour of #36534 |
Description
Filelist shows share indicators on files and folders, that reside inside a shared folder / shared folders.
The sidebar share-tab reveals a detailed view of the share-tree including share-recipients and the respective folders the life in.
Related Issue
https://github.com/owncloud/enterprise/issues/3453 (Discussion)
https://github.com/owncloud/enterprise/issues/3556 (Vis. Concept)
How Has This Been Tested?
Manual testing in
Types of changes
Checklist: