Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Execute unit tests with postgres:10.3 as well #34789

Closed
wants to merge 1 commit into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Mar 18, 2019

Backport #31330

(see if this works in stable10 these days)

Edit:
No, not working yet. Because of PHP 7.0 support in stable10 we cannot get to doctrine/dbal 2.8
We have only got to doctrine/dbal 2.5.3

So postgres:10.3 has to wait a bit longer.

@phil-davis phil-davis force-pushed the stable10-test-postgres-10 branch from 4a2a89e to 6cf73b7 Compare March 18, 2019 09:52
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #34789 into stable10 will decrease coverage by 19.15%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             stable10   #34789       +/-   ##
===============================================
- Coverage        64.2%   45.04%   -19.16%     
===============================================
  Files            1278      116     -1162     
  Lines           76246    11476    -64770     
  Branches         1291     1291               
===============================================
- Hits            48950     5169    -43781     
+ Misses          26917     5928    -20989     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 30.71% <ø> (-34.66%) 0 <ø> (-19883)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 59.45% <0%> (-21.64%) 0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1154 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99798da...6cf73b7. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #34789 into stable10 will decrease coverage by 19.15%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             stable10   #34789       +/-   ##
===============================================
- Coverage        64.2%   45.04%   -19.16%     
===============================================
  Files            1278      116     -1162     
  Lines           76246    11476    -64770     
  Branches         1291     1291               
===============================================
- Hits            48950     5169    -43781     
+ Misses          26917     5928    -20989     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 30.71% <ø> (-34.66%) 0 <ø> (-19883)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 59.45% <0%> (-21.64%) 0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1154 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99798da...6cf73b7. Read the comment docs.

@phil-davis phil-davis changed the title [stable10] Execute unit tests with postgre:10.3 as well [stable10] Execute unit tests with postgres:10.3 as well Mar 18, 2019
@phil-davis phil-davis closed this Mar 18, 2019
@phil-davis phil-davis deleted the stable10-test-postgres-10 branch March 18, 2019 10:04
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants