Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute unit tests with postgre:10.3 as well #31330

Merged
merged 1 commit into from
May 2, 2018
Merged

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented May 2, 2018

Description

We shall support postgres 10.3 as well

Related Issue

#31320

How Has This Been Tested?

  • PHP_VERSION=7.1 TEST_SUITE=phpunit DB_TYPE=postgres POSTGRES_IMAGE=postgres:10.3 drone exec

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the development milestone May 2, 2018
@DeepDiver1975 DeepDiver1975 self-assigned this May 2, 2018
@phil-davis
Copy link
Contributor

@DeepDiver1975 this is another PR where all drone has passed, but the codecov result has not got back to GitHub. It is happening to a few PRs today.

@codecov
Copy link

codecov bot commented May 2, 2018

Codecov Report

Merging #31330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #31330   +/-   ##
=========================================
  Coverage     62.59%   62.59%           
  Complexity    18227    18227           
=========================================
  Files          1145     1145           
  Lines         68414    68414           
  Branches       1234     1234           
=========================================
  Hits          42821    42821           
  Misses        25232    25232           
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.79% <ø> (ø) 18227 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e044095...a4e4f94. Read the comment docs.

@phil-davis
Copy link
Contributor

and hours later the codecov report pops out. what happened there???

@DeepDiver1975
Copy link
Member Author

Maybe some hickup in the Processing queue ....

@DeepDiver1975 DeepDiver1975 merged commit d15a22c into master May 2, 2018
@DeepDiver1975 DeepDiver1975 deleted the test-postgres-10 branch May 2, 2018 17:44
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@phil-davis
Copy link
Contributor

phil-davis commented Mar 18, 2019

Backport attempt was stable10 #34789

Does not work yet because of stable10 PHP7.0 support :(
#33187 (comment)

@phil-davis
Copy link
Contributor

This is coming "one day" to stable10 with "drop PHP 7.0" #35786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants