Properly detect thumbnail availability in PreviewPlugin #31785
Conversation
.htaccess
Outdated
| #### DO NOT CHANGE ANYTHING ABOVE THIS LINE #### | ||
|
|
||
| ErrorDocument 403 /core/templates/403.php | ||
| ErrorDocument 404 /core/templates/404.php |
There was a problem hiding this comment.
yeah... somehow .htaccess keeps on sneaking in
There was a problem hiding this comment.
I do that to myself quite often - running some tests, setting up stuff, whatever, makes the additions to the end of .htaccess
Then without thinking I git add -A and git commit - when I need to first git checkout .htaccess to get rid of the changed file.
There was a problem hiding this comment.
chmod a-w .htaccess and you are save forever
Use preview manager's "isAvailable" method. Also fixes isAvailable to properly recognize IProvider2 instances.
PVince81
force-pushed
the
previews-regression-mountpoint
branch
from
1f35648 to
d3630bd
Compare
|
Fixed unit test and php-cs |
Codecov Report
@@ Coverage Diff @@
## master #31785 +/- ##
============================================
+ Coverage 63.2% 63.24% +0.03%
- Complexity 18453 18455 +2
============================================
Files 1158 1158
Lines 69302 69305 +3
Branches 1261 1261
============================================
+ Hits 43802 43831 +29
+ Misses 25130 25104 -26
Partials 370 370
Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Use preview manager's "isAvailable" method.
Also fixes isAvailable to properly recognize IProvider2 instances.
Related Issue
Fixes #31763
Motivation and Context
How Has This Been Tested?
Manual test with external storage where previews are disabled (cog icon): network console shows 404 for every preview. Outside of external storage, previews still render.
Screenshots (if appropriate):
Types of changes
Checklist: