Disable 'Enable previews' option do not stop showing the thumbnails for an external storage mountpoint

[davitol]

Steps to reproduce

1 - Via webUI create a mountpoint e.g. a SMB one
2 - Browse to the Files view --> mountpoint and check the content (thumbnails are available)
3 - Browse back to the configuration and Unmark 'Enable previews' option
4 - Browse to the Files view --> mountpoint and check the content.
5 - Upload an image from your computer
6 - Using text editor create a file and edit it.

Expected behaviour

The thumbnails should not be available

Actual behaviour

The thumbnails are shown

Server configuration

Operating system:
Ubuntu 16.04

Web server:
Apache

Database:
MySQL

PHP version:
7.1

ownCloud version:

ownCloud stable10 from 13 june 2018

Updated from an older ownCloud or fresh install:
Fresh

Are you using external storage, if yes which one:
No

Are you using encryption:
No

Logs

No logs in owncloud.log

Client configuration

browser

Firefox

[patrickjahns]

Looking at the picture - I see that for "alonso.txt" no preview was generated - which of the txt files was created after you have changed it?

[davitol]

alonso.txt has no content. That's why it has no preview.
Claseburgos.jpeg was uploaded from local after unmarking the checkbox
caca.txt was the new file.txt after unmarking the checkbox

[patrickjahns]

@davitol

tested on 10.0.8 - steps done - behavior observed

1. create a mount ( local ) - enabled preview generation (mounted /tmp folder)
2. navigate to tmp
3. upload "krieg-der-welten.jpg" -> see preview being generated
4. navigato to admin mounts - disable preview generation
5. navigate to tmp folder
6. upload file "jenkins.png" -> no preview generated - nut preview of "krieg-der-welten" is still available

Needs testing with beta release to confirm if the regression was introduced recently

[ownclouders]

GitMate.io thinks possibly related issues are #23277 (disable external storages), #21646 (Using an external storage mountpoint, unchecking previews checkbox should disable the file previews), #9052 (Do not show delete icon for global external storage mounts), #12216 (config option for external storage), and #10198 (External Only Storage).

[davitol]

Tested on 10.0.8 - steps done - behavior observed

@patrickjahns

Just tested in 10.0.8 and cannot reproduce it too, so probably a regression introduced recently

[patrickjahns]

@PVince81 - moving to QA - as this is a regression introduced from 10.0.8 to 10.0.9beta

[PVince81]

Likely related to the preview API changes, it might be missing a check.

@davitol does disabling previews globally in config.php work ? I know some people use that for performance reasons.

[davitol]

@PVince81 'enable_previews' => false, works fine

[PVince81]

PR here: #31785

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.