Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.sample.php user.search_min_length #31156

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Apr 17, 2018

Description

Adding the key user.search_min_length to config.sample.php

Related Issue

owncloud-archive/documentation#4041

Motivation and Context

PR #30798 (Configurable minimum characters before autocomplete user searches) created the key but no description in config.sample.php was added.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

* time especially for large backends.
* If the query matches exact patterns even there are less characters entered,
* the backend will return these matches, eg "Tom" will return "Tom" if there is
* an exact match even the minimum charactes entered is 4.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any exact matches to a user or group will be returned,
even though less than the minimum characters have been entered.
e.g. entering "tom" will always return "Tom" if there is an exact match.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested text to replace the 3 lines above.

Copy link
Contributor Author

@mmattel mmattel Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So "tom" matches lower("Tom") = case insensitive?
Currently for me exact means case sensitive. Your statement is case insensitive.
What is the correct one?
The sentence itself is great, but I would like to add the case (in)sensitivness.
A proposal for it is welcomed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like exact match is case insensitive (and always was, not changed by the recent PR related to this setting)
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, will change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is case-insensitive matching in general. That is the "ordinary" existing behavior. I used "tom" and "Tom" as an exmaple because I did not want to give the idea that you have to start typing an uppercase letter to get a match on a display name.

Add "case-insensitive" somewhere in the text if you like.

@codecov
Copy link

codecov bot commented Apr 17, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@dccc39b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #31156   +/-   ##
=========================================
  Coverage          ?   62.55%           
  Complexity        ?    18279           
=========================================
  Files             ?     1147           
  Lines             ?    68472           
  Branches          ?     1234           
=========================================
  Hits              ?    42831           
  Misses            ?    25280           
  Partials          ?      361
Flag Coverage Δ Complexity Δ
#javascript 52.05% <ø> (?) 0 <ø> (?)
#phpunit 63.74% <ø> (?) 18279 <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dccc39b...3d892e6. Read the comment docs.

@mmattel mmattel force-pushed the config.sample.php_user.search_min_lengt branch from 0e0da3f to 3d892e6 Compare April 17, 2018 09:36
@felixboehm
Copy link
Contributor

Backport for 10.0.8 ?
@PVince81

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@PVince81 PVince81 merged commit 8ba3d9e into master Apr 17, 2018
@phil-davis
Copy link
Contributor

I can make a backport in just a few seconds...

@PVince81 PVince81 deleted the config.sample.php_user.search_min_lengt branch April 17, 2018 09:47
@phil-davis
Copy link
Contributor

Backport stable10 #31160

@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants