-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config.sample.php user.search_min_length #31156
Conversation
config/config.sample.php
Outdated
* time especially for large backends. | ||
* If the query matches exact patterns even there are less characters entered, | ||
* the backend will return these matches, eg "Tom" will return "Tom" if there is | ||
* an exact match even the minimum charactes entered is 4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any exact matches to a user or group will be returned,
even though less than the minimum characters have been entered.
e.g. entering "tom" will always return "Tom" if there is an exact match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested text to replace the 3 lines above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So "tom" matches lower("Tom") = case insensitive?
Currently for me exact means case sensitive. Your statement is case insensitive.
What is the correct one?
The sentence itself is great, but I would like to add the case (in)sensitivness.
A proposal for it is welcomed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, will change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is case-insensitive matching in general. That is the "ordinary" existing behavior. I used "tom" and "Tom" as an exmaple because I did not want to give the idea that you have to start typing an uppercase letter to get a match on a display name.
Add "case-insensitive" somewhere in the text if you like.
Codecov Report
@@ Coverage Diff @@
## master #31156 +/- ##
=========================================
Coverage ? 62.55%
Complexity ? 18279
=========================================
Files ? 1147
Lines ? 68472
Branches ? 1234
=========================================
Hits ? 42831
Misses ? 25280
Partials ? 361
Continue to review full report at Codecov.
|
0e0da3f
to
3d892e6
Compare
Backport for 10.0.8 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now
I can make a backport in just a few seconds... |
Backport |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Adding the key
user.search_min_length
to config.sample.phpRelated Issue
owncloud-archive/documentation#4041
Motivation and Context
PR #30798 (Configurable minimum characters before autocomplete user searches) created the key but no description in config.sample.php was added.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: