Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

Undocumented key in config.sample.php: user.search_min_length #4041

Closed
mmattel opened this issue Apr 16, 2018 · 6 comments
Closed

Undocumented key in config.sample.php: user.search_min_length #4041

mmattel opened this issue Apr 16, 2018 · 6 comments
Assignees

Comments

@mmattel
Copy link
Contributor

mmattel commented Apr 16, 2018

There is an undocumented key in https://github.com/owncloud/core/blob/6e2b8aa921f877b1b77fc8177ed987dd9da4560e/lib/public/Util/UserSearch.php#L69

user.search_min_length, default 4

Have not found the commit / by whom this was implemented

@PVince81 FYI

@PVince81
Copy link
Contributor

this is the matching ticket owncloud/core#30313, seems I missed that when reviewing

this is for the local share autocomplete:

  • the value limits the min characters for the backend to search for partial users or groups
  • the backend will still return exact matches even if less than the number of shares

@PVince81
Copy link
Contributor

cc @VicDeo

@mmattel
Copy link
Contributor Author

mmattel commented Apr 17, 2018

@PVince81 what does the sentence mean: "the backend will still return exact matches even if less than the number of shares"

@PVince81
Copy link
Contributor

@mmattel if there is a user called exactly "tom" and you search for "tom" despite 4 being the minimum characters, the dropdown will return "tom" because it's an exact match

however if you type "to" it will not as it's not an exact match

@phil-davis
Copy link
Contributor

I do not understand "than the number of shares" - what shares? how many shares are there?...

Maybe "the backend will return exact matches even if less than the minimum search length characters have been entered"

@mmattel
Copy link
Contributor Author

mmattel commented Apr 17, 2018

Info: PR has been merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants