Changing user display name does not change lock owner name

[phil-davis]

1. login as some user Alice with display name set to Original Name
2. lock a file or folder
3. change your display name to New name
4. view the locks tab of the file/folder details

Expected result

Lock owner is displayed as New Name

Actual result

Lock owner is displayed as Original Name

[ownclouders]

GitMate.io thinks possibly related issues are #3101 (Admin user can't change the Display Name of other Users), #809 (Lock or disable users), #1503 (Changing user password doesn't trigger hook listeners), #1371 (Display name not editable by user), and #9544 (Can't Change Full Name for Users).

[phil-davis]

The oc_persistent_locks table has stuff like:

mysql> select * from oc_persistent_locks;
+----+------------+------------------+---------------+---------+------------+--------------------------------------+----------------------------------+-------+-------+
| id | file_id    | owner_account_id | owner         | timeout | created_at | token                                | token_hash                       | scope | depth |
+----+------------+------------------+---------------+---------+------------+--------------------------------------+----------------------------------+-------+-------+
|  9 | 2147492032 |               57 | My fancy name |    1800 | 1548833262 | 9b86317e-6f3f-4d6b-91f3-2bd78029573a | dd2eb08e480e12c4277a178e96475572 |     2 |    -1 |
| 10 | 2147492031 |               57 | My fancy name |    1800 | 1548833262 | 458ee95b-a353-4876-abda-d331c3d9e537 | 8cbfb6821e0649a5afec948a325ea5f2 |     1 |    -1 |
+----+------------+------------------+---------------+---------+------------+--------------------------------------+----------------------------------+-------+-------+
2 rows in set (0.00 sec)

So I guess that owner field becomes stale.

Maybe the owner should be the username, and the current display name should be looked up on-the-fly.

[phil-davis]

Note: oc_persistent_locks already has field owner_account_id

IMO the username (UID), display name, email address etc can be found by looking up the information starting from the owner_account_id - so probably the owner field is redundant and could be dropped.

"not storing redundant data" = "no chance for the redundant data to become stale"

[phil-davis]

Removed the QA-team label because this has a test to cover the behavior.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.