Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing user password doesn't trigger hook listeners #1503

Closed
samtuke opened this issue Feb 6, 2013 · 4 comments
Closed

Changing user password doesn't trigger hook listeners #1503

samtuke opened this issue Feb 6, 2013 · 4 comments
Labels
Milestone

Comments

@samtuke
Copy link
Contributor

samtuke commented Feb 6, 2013

pre_setPassword and post_setPassword do not call methods that have been connected to them.

Apps can't know when the user pwd is changed or react to this event.

@samtuke
Copy link
Contributor Author

samtuke commented Feb 6, 2013

This is caused by the try statement which wraps OC::getRouter()->match() in base.php (line 558) returning before loadApps() can be called.

@bartv2 do you have time to take a look at this?

@bartv2
Copy link
Contributor

bartv2 commented Feb 6, 2013

The match function will try to lookup the route and when it finds it the action will be executed. When no route is found the ResourceNotFoundException is thrown, this will fallthrough to the previous ?app=&file= code.

Commit 8ce3aca removed the loading of all apps from the try block, because the app settings page wasn't updating the menu correctly with this.

@MTGap
Copy link
Contributor

MTGap commented Feb 6, 2013

Well we need an alternative for requests that aren't for app pages.

@bartv2
Copy link
Contributor

bartv2 commented Mar 4, 2013

we now load the apps before matching the route, so all apps should be loaded. This issue should be fixed now.

@bartv2 bartv2 closed this as completed Mar 4, 2013
@lock lock bot locked as resolved and limited conversation to collaborators Aug 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants