Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Create "Open in web" option in main file list #4058

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Jun 6, 2023

Related Issues

App: #3860

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@JuancaG05 JuancaG05 self-assigned this Jun 6, 2023
@JuancaG05 JuancaG05 linked an issue Jun 6, 2023 that may be closed by this pull request
9 tasks
@JuancaG05 JuancaG05 changed the base branch from master to feature/filter_menu_usecase June 6, 2023 12:46
@jesmrec
Copy link
Collaborator

jesmrec commented Jun 8, 2023

Tested over two servers that support app providers. So, tests are restricted to

  • Files with MIME supported by two providers
  • Files with MIME supported by one provider (images, in this test case)
  • Files without MIME supported
  • Folders (not supported)
  • Multiselection (not supported)
  • Details view (regression behaviour)

The only minor detail is that the string overflows the menu width in list of files (does not happen in Details):

Screenshot 2023-06-08 at 13 35 41

Since we plan to move all the options to bottom sheet , it's not a problem to keep that behaviour.

No problem from my side to move this forward.

@JuancaG05 JuancaG05 force-pushed the feature/open_in_web_main_list branch from 583e308 to 5471b03 Compare June 8, 2023 12:08
@JuancaG05 JuancaG05 force-pushed the feature/filter_menu_usecase branch from e131926 to e5b0da7 Compare June 12, 2023 06:38
Base automatically changed from feature/filter_menu_usecase to master June 12, 2023 07:06
@JuancaG05 JuancaG05 force-pushed the feature/open_in_web_main_list branch from 5471b03 to b03b1b5 Compare June 12, 2023 07:20
@JuancaG05 JuancaG05 merged commit bd4a314 into master Jun 12, 2023
@JuancaG05 JuancaG05 deleted the feature/open_in_web_main_list branch June 12, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Create "Open in web" option in main file list
3 participants