Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Show "More" button for every file list item #2885

Closed
11 tasks done
hosy opened this issue May 29, 2020 · 12 comments · Fixed by #4076
Closed
11 tasks done

[FEATURE REQUEST] Show "More" button for every file list item #2885

hosy opened this issue May 29, 2020 · 12 comments · Fixed by #4076
Assignees
Labels
Estimation - 5 (L) Feature request File list p2-high Escalation, on top of current planning, release blocker
Milestone

Comments

@hosy
Copy link
Collaborator

hosy commented May 29, 2020

At the moment if I want to run an action on a file item like Delete, Copy, Move, ... I have to select the item before.

Describe the solution you'd like
It would be cool to have the "…" button on every file list item, like in the iOS app, which no longer needs to select the item, before running an action on it.

TASKS

  • Research (if needed)
  • Create branch feature/three_dots_menu_per_file
  • Development tasks
    • Add 3-dot menu to every file cell
    • Move share (with users and by link) icons to subtitle line of the file cell (together with size and modification date)
    • Remove shared folder thumbnail
    • Make a bottom sheet with the options that appear in the menu in single selection
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/three_dots_menu_per_file into master
@abelgardep
Copy link
Contributor

Thanks for creating the issue!! This is an improvement we want to develop as part of #2742. There are still some issues required before, but this is in our backlog for sure.

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 13, 2023

To do:

  • Add three-dot-button to every cell
  • Add sheet with actions available for every item (same as displayed in current way except for "Select all" and "Select inverse" options). Icon already exists, showing it. Scrollable if posible.
  • Re-allocate share icons: add to subtitle an icon if the itemi is shared by link and another one if it is shared with user
  • Remove folder thumbnail with sharing icons. Repeated information.
  • Multiselection:
    • Enabled with long-press, no changes
    • Where do we have to show list of operations? In three-dot-button on the top, as before
    • Grid mode: how does it match? no room for 3-dot-button. Multiselection enabled by long-pressing as always
    • If only 1 item is selected, should we show list of operations? yes.
    • So, in conclusion, multiselection keeps exactly the same behaviour as before
  • Add Open in web to new actions menu -> [FEATURE REQUEST] Create "Open in web" option in main file list #3860

@JuancaG05
Copy link
Collaborator

This is how the menu for the 3-dot button in each row looks like when pressing:

File is not downloaded File is downloaded Folder

As you may notice, the options "Select all" and "Select inverse" don't appear here, they'll be available just for multi selection, like they are now. The rest of options do appear here, but don't have any kind of order, I just placed "Remove" in the last place because it's the most painful option and thus it should appear the last one.

Any suggestions for this design? Which order do you suggest? Maybe we can keep the same order than we have in the 3-dot menu when long-pressing a file, or if we want to perform changes in the order of the options of that menu the moment is now? The current order is:

(Share and Synchronize options appear as buttons in the toolbar for quicker access)

@michaelstingl @tbsbdr @jesmrec @manuelplazaspalacio @Aitorbp feedback is welcome 😀

@JuancaG05
Copy link
Collaborator

This is the order I propose:

File is not downloaded File is downloaded Folder

First we'll find the Details option, that is where we're redirected when we press on the row. Then we'll find Download, which is substituted by Synchronize in the same position when the file is downloaded. After this, we'll find some file operations like Rename, Move and Copy and then, operations related with other apps such as Open with, Share and Send. Finally, we can find the Set as available offline or Unset as available offline options, which are related with the sync status of the file, and last, we can find Remove. In the case of folders, the order is the same but skipping the options that do not proceed.

@JuancaG05
Copy link
Collaborator

JuancaG05 commented Jul 5, 2023

BTW, the shared icons have been improved here as well, taking advantage that we had to move them to include the 3-dot icon:

  • Now, the icons appear in the subtitle of the file, just next to the size and modification date.
  • If it was shared with users or groups, we'll find the typical share icon there.
  • If it was shared via public link, we'll find a chain icon there.
  • If it was shared both ways, both icons will appear. Previously, if it was shared both ways, we could only see the chain icon.
  • Folder thumbnails when shared have been removed since it is repeated information, and this way they are more consistent with the rest of file types (not changing thumbnail depending on their share status).

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 7, 2023

About the order in which the options are set: does it follow any rule @JuancaG05 ? f. ex, IMO Details fits better nearer to the bottom, and Share nearer to the top. @michaelstingl @tbsbdr what do you think? ⬆️ ⬆️

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 7, 2023

In case of the app providers, you are using an specific icon for any of them. Were there any problem to add the one from the app provider endpoint? or is it something to do in another moment?

@michaelstingl
Copy link
Contributor

About the order in which the options are set: does it follow any rule @JuancaG05 ?

Align with ownCloud web or iOS app?

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 7, 2023

For the same item:

oCIS iOS Android
Screenshot 2023-07-07 at 11 09 03 Screenshot 2023-07-07 at 11 10 31 Screenshot 2023-07-07 at 11 13 04

So, my proposal (open to critics):

Share, Open in , Open with, Download/Sync, Rename, Move, Copy, Send, Set/Unset as av. offline, Details, Remove

I'd rather the destructive option at the bottom (difference to oCIS), the options to handle the item on the top, and the others in the middle

More ideas welcome.

@JuancaG05
Copy link
Collaborator

About the app providers icon, that's something to do at the moment, currently we are not retrieving the icons from the server, so I set a default icon for every "Open in web" option. About the order of the options, as soon as you decide which order you prefer (maybe aligning it with oCIS web is not the most suitable here) I will apply the changes @jesmrec

@tbsbdr
Copy link

tbsbdr commented Jul 7, 2023

I once compared the ranking of context-menu items within other solutions for web and tried to find a median. what you currently see in web is the outcome of that research. but i think the order needs improvement, any suggestions @JuancaG05 @jesmrec ?

image

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 10, 2023

Conclusions:

  • Share on the top (or nearer to the top)
  • Details on the bottom (or nearer to the bottom)
  • Delete is set on the top or on the bottom, so the median does not help in this case. IMO, destructive actions should be placed in the bottom.
  • Actions like move, copy, rename etc... are place in the middle
  • Download nearer to the top

So, my proposal is the same i did before:

Share
Open in provider
Open with
Download/Sync
Rename
Move
Copy
Send
Set/Unset as av. offline
Details
Remove

would it be OK @tbsbdr? we can iterate if more feedback comes to us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimation - 5 (L) Feature request File list p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants