-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECHNICAL] Move available operations in file list to UseCase #4009
Comments
The old filter, and thus the new use case, is used in the next screens:
The filter consists of various menu options and parameters to select which of them must be shown in each case:
In addition, the following screens have additional restrictions:
|
Let's QA |
(1) [FIXED]
Not reproducible in oCIS Current: Share option is not available Pixel2, Android11 |
(2) [FIXED]
Current: Share option is not available Pixel2, Android11 |
(3) [FIXED]May be related with (1)
Current: Share option is not available Pixel2, Android11 |
(4)Questions:
|
(1), (2) and (3) should be fixed now 👍
Yes, they are. They have a tiny dynamic behaviour since "Select all" is only shown when not every file is selected and we are in the main file list, and "Select inverse" only when we are in the main file list. We could separate them from the filter but then we would spread the menu options logic in several parts of the code...
That's correct, it is the same preview but displayed differently if it's a |
This is the test matrix: Single selection
Multiple selection
|
Approved on my side |
Let's move the legacy
FileMenuFilter.java
class to Kotlin and transform it to use case.TASKS
FileMenuFilter
to use caseFileMenuFilter
uses by the new use caseFileMenuFilter
QA
Test plan:
Reports & improvements
The text was updated successfully, but these errors were encountered: