Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share text when using public share includes username instead of the full name #3636

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Share text when using public share includes username instead of the full name #3636

merged 3 commits into from
Apr 22, 2022

Conversation

davcres
Copy link
Contributor

@davcres davcres commented Apr 21, 2022 •
edited by fesave
Loading

Related Issues

App: #1106

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@davcres davcres requested review from abelgardep and fesave April 21, 2022 07:14
@davcres davcres self-assigned this Apr 21, 2022
@davcres davcres linked an issue Apr 21, 2022 that may be closed by this pull request
Share text when using public share includes username instead of the full name #1106
Closed
fesave
fesave approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@fesave fesave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 21, 2022

Easy one. Approved on my side

@davcres davcres force-pushed the feature/share_full_name branch from bd81abf to b07f108 Compare April 22, 2022 07:09
@abelgardep abelgardep merged commit 2b75c11 into master Apr 22, 2022
@abelgardep abelgardep deleted the feature/share_full_name branch April 22, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fesave fesave fesave approved these changes

@abelgardep abelgardep Awaiting requested review from abelgardep

Assignees

@davcres davcres

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Share text when using public share includes username instead of the full name
4 participants
@davcres @jesmrec @fesave @abelgardep