Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share text when using public share includes username instead of the full name #1106

Closed
godfuture opened this issue Aug 22, 2015 · 5 comments · Fixed by #3636
Closed

Share text when using public share includes username instead of the full name #1106

godfuture opened this issue Aug 22, 2015 · 5 comments · Fixed by #3636

Comments

@godfuture
Copy link

Background
I shared files on my Android device with Owncloud by public link sent over Whatsapp.

Issue
The name used to indicate the share action: "XXX shares yyy with you" is done with user name, not with full name. But how does the receiver of me know who this user is? Maybe user names were created with some cryptic pattern or appreviations. I guess using the full name to indicate a share text makes much more sense.

@masensio
Copy link

Hi @godfuture,

We are using the account username in the share message.
When you say "full name", do you mean the full account name (like username@server)?

@tobiasKaminsky
Copy link
Contributor

I think he means the real name with forename und surname.
Maybe something like that:
Username: mk83
Real name: Martin Klug

@masensio
Copy link

@tobiasKaminsky,

in that case, we need to access to the Display Name of the account. In the current implementation the app doesn't save this information into the Account.

I don't know if we can access to the Display Name with a GET USER request, maybe it is possible.

Any volunteer?

@godfuture
Copy link
Author

@tobiasKaminsky is absolutely right.
I speak about the real name (vollständiger Name -> full name) that is managed on personal owncloud page.

Sorry for my late response!

@davivel
Copy link
Contributor

davivel commented Oct 19, 2016

Display names are already available in the app; for example, navigation drawer shows it in the header. So, this should be doable without worrying about accessing the server.

@jesmrec jesmrec added this to the 2.21-current milestone Apr 7, 2022
@theScrabi theScrabi changed the title Share text when using public share includes username instead full name Share text when using public share includes username instead of full name Apr 8, 2022
@theScrabi theScrabi changed the title Share text when using public share includes username instead of full name Share text when using public share includes username instead of the full name Apr 8, 2022
@davcres davcres self-assigned this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants
@davivel @masensio @godfuture @tobiasKaminsky @jesmrec @abelgardep @davcres and others