Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed visibility of privacy policy drawer's option. #3542

Merged
merged 4 commits into from
Feb 4, 2022
Merged

Fixed visibility of privacy policy drawer's option. #3542

merged 4 commits into from
Feb 4, 2022

Conversation

fesave
Copy link
Contributor

@fesave fesave commented Feb 2, 2022 •
edited
Loading

Related Issues

App: #3521

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@fesave fesave self-assigned this Feb 2, 2022
@fesave fesave linked an issue Feb 2, 2022 that may be closed by this pull request
[BUG] Privacy policy link is not hidden in drawer when setting is false #3521
Closed
@fesave fesave marked this pull request as ready for review February 2, 2022 13:01
JuancaG05
JuancaG05 requested changes Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny change here @fesave 👍

changelog/unreleased/3542 Outdated Show resolved Hide resolved
@fesave fesave requested a review from JuancaG05 February 2, 2022 13:13
JuancaG05
JuancaG05 approved these changes Feb 3, 2022
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 3, 2022

QA checks

  • privacy_policy_enabled == true -> visible in settings and drawer
  • privacy_policy_enabled == false -> hidden in settings and drawer
  • migrate false -> true` -> it becomes visible
  • migrate true -> false` -> it becomes hidden

Approved on my side

@abelgardep abelgardep force-pushed the fix/hide_privacy_policy branch from 73dc512 to f720bbb Compare February 4, 2022 13:19
@abelgardep abelgardep merged commit 468b628 into master Feb 4, 2022
@abelgardep abelgardep deleted the fix/hide_privacy_policy branch February 4, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

@abelgardep abelgardep Awaiting requested review from abelgardep

Assignees

@fesave fesave

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Privacy policy link is not hidden in drawer when setting is false
4 participants
@fesave @jesmrec @JuancaG05 @abelgardep