[Fix] Camera Uploads manual retry

[abelgardep]

Related Issues

App: #3417

Library PR (if needed):

• Added changelog files for the fixed issues in folder changelog/unreleased. More info here

---

QA

• (1) Cell retry [Fix] Camera Uploads manual retry #3418 (comment) [WONT FIX]
• (2) move behaviour after failing [Fix] Camera Uploads manual retry #3418 (comment) [FIXED]

[JuancaG05]

💯

[selius]

Thanks for the fix, @abelgardep!

One issue I found is that it removed the original file, even though in my settings it's set to keep them. But that's probably because MOVE and COPY constants were mixed up. 🙂

Another thing I noticed is there's no progress bar for the upload in the notifications and the view is not refreshed after the file was successfully uploaded to the server. That is, it's still showing as "failed" and only updated when I switch to another tab and then back to Uploads.

[abelgardep]

Another thing I noticed is there's no progress bar for the upload in the notifications and the view is not refreshed after the file was successfully uploaded to the server. That is, it's still showing as "failed" and only updated when I switch to another tab and then back to Uploads.

That's right @selius It's a known issue that affects camera uploads. We need to move forward with the new architecture to fix and unify the process 👍

Thank you so much for your comments and feedback. It's highly appreciated!!

[jesmrec]

(1)

1. Enable camera uploads
2. Take some pictures
3. Switch server off
4. Wait 15 minutes

Current: Files are in Failed section in uploads view. By clicking on individual rows, nothing happen. The wat to retry is clicking the retry button to retry all at once. Same behaviour with manual uploads is different. If the manual upload fails, clicking on every individual row is posible.

Expected: Same behaviour in both (feasible?)

Pixel2 Android11
786dfa1a

[jesmrec]

(2) [FIXED]

1. Enable camera uploads
2. Select "move" in the behaviour
3. Take some pictures
4. Switch server off.
5. Wait 15 minutes
   ...
6. When uploads fail, then switch server on and retry

Current: files are copied, not moved
Expected: files are moved, removed from internal

NOTE: the move behaviour works fine when uploads run without errors

Pixel2 Android11
786dfa1a

[fesave]

LGTM

[abelgardep]

(1)

1. Enable camera uploads
2. Take some pictures
3. Switch server off
4. Wait 15 minutes

Current: Files are in Failed section in uploads view. By clicking on individual rows, nothing happen. The wat to retry is clicking the retry button to retry all at once. Same behaviour with manual uploads is different. If the manual upload fails, clicking on every individual row is posible.

Expected: Same behaviour in both (feasible?)

Pixel2 Android11 786dfa1a

Actually, if you click on any individual row, they are retried. This is the fix for it. In master they are not retried. The point here is that you can not see actual feedback about it (Only a notification if it fails again) until you enter the uploads view again.

But that is a different issue that is already in master with camera uploads retry all.

[abelgardep]

About (2), yes, MOVE behavior was broken for camera upload retries. COPY was used by default, so they actually are not removed after a successful upload. I'll fix it and let you know 👍

[jesmrec]

Approved

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information