[BUG] Can't manually retry a failed camera upload #3417
Comments
Good morning @selius! Thanks for your work, collaborators are always welcome! In principle, your solution looks good. Don't worry, I encourage you to open a PR, you are welcome to join and our team of developers will be happy to help you and teach you more about the project, I hope to hear from you soon! Cheers! |
|
Thank you so much for reporting this @selius You are completely right! We handled the We will handle both from now on. |
|
I'm on Android Samsun SE20 - the app is the current latest 4.3.0. (573707a) RETRY doesn't work.... and when I click on the individual files - I get the error message "The file was not found in the local file system"
Please see above screenshot. |
|
@hodfords, which option do you set in the |
|
These are settings in the auto-uploads.
|
|
Reopening, will take a look there. Did you catch some logs about the problem? |
|
you mean on the server side? or the app side? |
|
Here you go; I've had to obsufcate the user name and email addresss and truncate the message:- D: 2024-08-12 17:00:37:758(LogsProvider.kt:49)release start logging 4.3.1 e0a273b Not FoundThe requested URL /boo/graph/v1.0/me/drives was not found on this server. Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request. E: 2024-08-12 17:00:42:825(GetRemoteSpacesOperation.kt:76)Failed response while getting spaces for user Not FoundThe requested URL /boo/graph/v1.0/me/drives was not found on this server. Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request. E: 2024-08-12 17:00:42:871(GetRemoteSpacesOperation.kt:76)Failed response while getting spaces for user I: 2024-08-12 17:00:44:651(UploadFileFromSystemUseCase.kt:58)Plain upload of /data/user/0/com.owncloud.android/files/owncloud/tmp/[email protected]%2Fboo/Phones/Samsung_SE20//20240505_191245.mp4 has been enqueued. I: 2024-08-12 17:00:44:700(UploadFileFromSystemUseCase.kt:58)Plain upload of /data/user/0/com.owncloud.android/files/owncloud/tmp/[email protected]%2Fboo/Phones/Samsung_SE20//20240507_103051.mp4 has been enqueued. D: 2024-08-12 17:00:44:721(OwnCloudClient.java:129)Executing in request with id 744819fc-2775-4ac9-80d4-6535ad9a5872 I: 2024-08-12 17:00:44:749(UploadFileFromSystemUseCase.kt:58)Plain upload of /data/user/0/com.owncloud.android/files/owncloud/tmp/[email protected]%2Fboo/Phones/Samsung_SE20//20240507_142126.mp4 has been enqueued. E: 2024-08-12 17:00:44:770(UploadFileFromFileSystemWorker.kt:120)com.owncloud.android.domain.exceptions.LocalFileNotFoundException I: 2024-08-12 17:00:44:787(UploadFileFromSystemUseCase.kt:58)Plain upload of /data/user/0/com.owncloud.android/files/owncloud/tmp/[email protected]%2Fboo/Phones/Samsung_SE20//20240505_191245.mp4 has been enqueued. I: 2024-08-12 17:00:44:813(UploadFileFromSystemUseCase.kt:58)Plain upload of /data/user/0/com.owncloud.android/files/owncloud/tmp/[email protected]%2Fboo/Phones/Samsung_SE20//20240506_100947.mp4 has been enqueued. D: 2024-08-12 17:00:44:836(UploadFileFromFileSystemWorker.kt:149)Upload with id (8679) has been found in database. D: 2024-08-12 17:00:44:846(UploadFileFromFileSystemWorker.kt:149)Upload with id (8681) has been found in database. ....... V: 2024-08-12 17:00:52:219(MainApp.kt:212)UploadListActivity onPause() ending |
|
Same problem with my partner's phone which is also Samsung. |
|
Thanks, will take a look. In case we'll not find something interesting in the logs, other option is getting a test account on your server, to check if server is somehow involved. |
|
We might be facing a race condition issue here. When we click on |
|
Let us know if you want me to try to create test account on my server... The key thing is I have like 10,000+ photos/videos on my phone... I don't understand why there isn't a mechanism to re-add the pictures and/or search for the same picture (using filename + size) in the media directory instead of getting things stuck...... I'm a developer too but not on Kotlin... |
|
Not a problem, we would add pictures to check.
this is a different feature like folder sync, not auto uploads. It's in our roadmap. About test server, you can send your server url and credentials: https://infinite.owncloud.com/s/YiFzgStJUjaHtrE |
|
Just uploaded a test account @jesmrec |
|
@hodfords i couldn't reproduce the problem on your server. Do you mind any action you did that could trigger the folder error? |
Hi,
It looks like in one of the recent versions you guys started to use content:// URIs instead of local paths to handle camera uploads.
This works fine, but when an upload fails for some reason (like, the server is unavailable or no permissions to write to the upload directory), clicking on the upload in the Uploads list to retry it shows a "The file was not found in the local file system" message and does nothing.
From my quick debugging session, I found out that it happens because the code in the
OnClickListenerthat's set inExpandableUploadListAdapter.getViewstill expects the source path to be local and usesFile.existson it:Although I fixed it for myself by also trying to pass the path to
DocumentFile.fromSingleUri, but I don't think I have enough overall knowledge of the project to suggest a good PR for this, so just letting you guys know.The text was updated successfully, but these errors were encountered: