Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Passcode input misbehaving #3365

Merged
merged 3 commits into from
Sep 3, 2021
Merged

[FIX] Passcode input misbehaving #3365

merged 3 commits into from
Sep 3, 2021

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Aug 31, 2021 •
edited
Loading

Related Issues

App: #3342

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@JuancaG05 JuancaG05 requested a review from abelgardep August 31, 2021 14:37
@JuancaG05 JuancaG05 self-assigned this Aug 31, 2021
@JuancaG05 JuancaG05 linked an issue Aug 31, 2021 that may be closed by this pull request
Passcode input misbehaving #3342
Closed
7 tasks
@JuancaG05 JuancaG05 requested a review from fesave August 31, 2021 15:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 703 Bugs
Vulnerability C 21 Vulnerabilities
Security Hotspot E 16 Security Hotspots
Code Smell A 3788 Code Smells

0.0% 0.0% Coverage
2.3% 2.3% Duplication

fesave
fesave approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@fesave fesave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abelgardep
Copy link
Contributor

It will be tested within #3354

@abelgardep abelgardep merged commit 29b669e into new_arch/passcode Sep 3, 2021
@abelgardep abelgardep deleted the fix/select_passcode_fields branch September 3, 2021 07:45
@abelgardep abelgardep mentioned this pull request Sep 7, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fesave fesave fesave approved these changes

@abelgardep abelgardep Awaiting requested review from abelgardep

Assignees

@JuancaG05 JuancaG05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passcode input misbehaving
3 participants
@JuancaG05 @abelgardep @fesave