Passcode input misbehaving

[theScrabi]

Actual behaviour

Pin code input behaves janki when one of the EditText fields is selected and its Value gets deleted.

Expected behaviour

EditText field should not be select at all. They should only indicate how much of the pin code was entered so far. The delete button should only delete the last entered digit.

Steps to reproduce

1. enable Pin code
2. open Pin Code Acitivity
3. enter half of the pin code
4. select one of the input fields
5. hit the delete button

Additional information

pincode_fail.mp4

Proposed fix

Maybe it is useful if we wrote our own custom view for the pin input. It should not be hard as no input must be processed by it.
Here a possible mock up:

TASKS

• Create branch fix/select_passcode_fields
• Development tasks
  • Make passcode fields not selectable
• Code review and apply changes requested
• Design test plan
• QA
• Merge branch fix/select_passcode_fields into master

[jesmrec]

Some device/vendor dependency here. I tested with:

Pixel2 Android11
Huawei P20 Android9
Nexus6P Android7

and not reproducible. In any case, the custom view implementation could be productive and interesting.

[theScrabi]

I tested again, I can reproduce this on any device.

[jesmrec]

Now reproduced correctly with all devices. Touches must not be allowed in the passcode gaps.

[theScrabi]

Maybe we should talk about redesigning the whole passcode activity in general. @michaelstingl what do you think?

[michaelstingl]

Maybe we should talk about redesigning the whole passcode activity in general. @michaelstingl what do you think?

Why? Currently it's not an urgency? Let's check Monday morning…

[JuancaG05]

For the moment, I will fix this by making the fields not selectable. A redesign of this activity could be addressed in another issue.

[abelgardep]

Already merged into #3361 so it will be tested as part of #3354 PR