Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the music icon with the branded toolbar color #3297

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

abelgardep
Copy link
Contributor

@abelgardep abelgardep commented Jul 2, 2021

Related Issues

App: #3272

Let's use the same color as the toolbar, I think it is the more consistent way.

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@abelgardep abelgardep self-assigned this Jul 2, 2021
@abelgardep abelgardep linked an issue Jul 2, 2021 that may be closed by this pull request
@abelgardep abelgardep force-pushed the enhancement/update_music_icon_color branch from 41e6e30 to 0df303c Compare July 2, 2021 12:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 5, 2021

Cool! much better using the toolbar color. Looks much better than the primary color.

Approved.

@jesmrec jesmrec self-requested a review July 5, 2021 07:55
@abelgardep abelgardep merged commit 5cb04a0 into master Jul 5, 2021
@abelgardep abelgardep deleted the enhancement/update_music_icon_color branch July 5, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Note icon in music player to be branded
2 participants