Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note icon in music player to be branded #3272

Closed
jesmrec opened this issue Jun 1, 2021 · 0 comments · Fixed by #3297
Closed

Note icon in music player to be branded #3272

jesmrec opened this issue Jun 1, 2021 · 0 comments · Fixed by #3297
Assignees
@abelgardep
Labels
Estimation - 1 (XS) p2-high Escalation, on top of current planning, release blocker UI / UX
Milestone
2.18.1

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Jun 1, 2021 •
edited
Loading

Related to #3121

The note icon is tinted with the main color of the app. Conceptually, this is correct.

Tecnically, the color is set in this way, using @color/primary

The list of colors is not brandable itself, it should be used as a parameter inside setup.xml afaik. i guess the affected key is: primary_button_background_color, corresponding to Primary color in internal branding.
@jesmrec jesmrec added the UI / UX label Jun 1, 2021
@jesmrec jesmrec added this to the 2.19-next milestone Jun 2, 2021
@jesmrec jesmrec added Estimation - 1 (XS) p2-high Escalation, on top of current planning, release blocker labels Jun 4, 2021
@jesmrec jesmrec added the Sprint label Jun 18, 2021
@abelgardep abelgardep self-assigned this Jul 2, 2021
@abelgardep abelgardep mentioned this issue Jul 2, 2021
Merged
1 task
@abelgardep abelgardep linked a pull request Jul 2, 2021 that will close this issue
Update the music icon with the branded toolbar color #3297
Merged
1 task
@jesmrec jesmrec removed the Sprint label Jul 9, 2021
@abelgardep abelgardep modified the milestones: 2.19-current, 2.18.1 Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abelgardep abelgardep

Labels
Estimation - 1 (XS) p2-high Escalation, on top of current planning, release blocker UI / UX
Projects
None yet
Milestone
2.18.1
Development

Successfully merging a pull request may close this issue.

Update the music icon with the branded toolbar color owncloud/android
2 participants
@jesmrec @abelgardep