Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank view in music player #3121

Closed
6 of 8 tasks
jesmrec opened this issue Feb 26, 2021 · 13 comments · Fixed by #3182
Closed
6 of 8 tasks

Blank view in music player #3121

jesmrec opened this issue Feb 26, 2021 · 13 comments · Fixed by #3182

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 26, 2021

While the music is reproduced, something should be shown to replace the white background: artwork, cover, a placeholder image...

As first improvement, setting an music icon on the background is enough. Then, we will iterate to improve.

device-2021-02-23-132712

TASKS

  • Research (if needed)
  • Create branch feature/feature_name
  • Development tasks
    • Implement icon design
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master

PR

  • App
  • Library (if needed)

PR: #3182

@theScrabi
Copy link
Contributor

theScrabi commented Mar 11, 2021

Showing a full Music artwork would possibly be the nicest solution, but it's also the solution that takes the most effort and time. Therefore until we can work on this I thought we could put some place holder here to at least not have to see the vast white void.
Here are 3 Design proposals. Please give me your opinion about this :)

1, 2, 3 what will it be?

1 2 3
1 2 3

@michaelstingl
Copy link
Contributor

@tbsbdr ⬆️

@tbsbdr
Copy link

tbsbdr commented Mar 11, 2021

i would go with 2 but any other decision is fine as well because this is a question of taste.

@jesmrec
Copy link
Collaborator Author

jesmrec commented Mar 11, 2021

i like the 2

@jesmrec jesmrec added Sprint and removed Sprint labels Mar 26, 2021
@theScrabi
Copy link
Contributor

Second it is then :)

@theScrabi
Copy link
Contributor

theScrabi commented Mar 30, 2021

Ok so I found out we can already handle coverart. Though it looks a bit weird. The web frontend tries to make coverart rectangular while we just show what we get.
With your permission I would change this to.

current state my suggestion
Bild_fix cover_small

What web frontend shows:
grafik

@theScrabi
Copy link
Contributor

theScrabi commented Mar 30, 2021

Just a design peak for a possible future solution. This could be implemented with simple drawable overlay and gradients:
new_art new_art_blank

@theScrabi theScrabi linked a pull request Mar 30, 2021 that will close this issue
@theScrabi
Copy link
Contributor

theScrabi commented Apr 7, 2021

I need yet another decisions

1 #cccccc 2 @color/gray 3 @color/primary 4: Gone wild (additional dev time required)
Clipboard - 7  April 2021 12_41-0 Clipboard - 7  April 2021 12_41-1 Clipboard - 7  April 2021 12_41-2 grafik

@LukasHirt
Copy link
Collaborator

I need yet another decisions

I love the 4th one! 🚀

@kulmann
Copy link
Member

kulmann commented Apr 7, 2021

Agreeing with @LukasHirt on the 4th one! 💪

@theScrabi
Copy link
Contributor

Ok I made this. It is 4. But without the overlay and the shadow gradient behind:
asdf

@pascalwengerter
Copy link

pascalwengerter commented Apr 7, 2021

I don't dislike option 4 too much, but it reminds me of OC10 and we're not using black as a prominent color in owncloud.design (and therefore in the new web frontend) - how about something like this?

Screenshot 2021-04-07 at 13 31 05

@theScrabi
Copy link
Contributor

Ok here the design with primary color:
asdf-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants