improve music player design #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
theScrabi
force-pushed
the
feature/styled_player_view
branch
4 times, most recently
from
31debf9 to
91d862a
Compare
abelgardep
suggested changes
Apr 5, 2021
There was a problem hiding this comment.
Some questions here @theScrabi.
BTW, do not forget to add the changelog item as described here
owncloudApp/src/main/res/layout-land/preview_audio_fragment.xml
Outdated
Show resolved
Hide resolved
theScrabi
force-pushed
the
feature/styled_player_view
branch
3 times, most recently
from
f661577 to
fb4a52b
Compare
abelgardep
suggested changes
Apr 7, 2021
| android:src="@drawable/logo" /> | ||
| android:scaleType="centerCrop" | ||
| android:src="@drawable/ic_place_holder_music_cover_art" | ||
| app:layout_constraintBottom_toBottomOf="parent" /> |
There was a problem hiding this comment.
The parent is not a Constraint layout, we don't need this constraint here, am I right?
theScrabi
force-pushed
the
feature/styled_player_view
branch
2 times, most recently
from
e67a86b to
0658993
Compare
abelgardep
approved these changes
Apr 9, 2021
|
Checked with Android 7 & Android 11, new background image correctly displayed in both and both orientations. Not much to test here Approved |
remove relative layout
use primary color as coverart background
abelgardep
force-pushed
the
feature/styled_player_view
branch
from
76bac07 to
8e5306c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #3121